From: M. J. T. Guy <mjtg@cus.cam.ac.uk>
Date: Wed, 15 Jul 1998 12:41:14 +0000 (+0100)
Subject: minor re.pm cleanup
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=8202fd39354c88c225e4200fee9877f5a082eebe;p=p5sagit%2Fp5-mst-13.2.git

minor re.pm cleanup
	Message-Id: <E0ywPvu-0003V7-00@ursa.cus.cam.ac.uk>
	Subject: Re: [PATCH 5.004_74]Don't use tainted REs in Basename.pm when building perl

p4raw-id: //depot/perl@1550
---

diff --git a/ext/re/re.pm b/ext/re/re.pm
index 8b49ca1..4a44753 100644
--- a/ext/re/re.pm
+++ b/ext/re/re.pm
@@ -81,11 +81,9 @@ sub bits {
     }
     foreach my $s (@_){
       if ($s eq 'debug') {
-	  eval <<'EOE';
-	    use DynaLoader;
-	    @ISA = ('DynaLoader');
-	    bootstrap re;
-EOE
+	  require DynaLoader;
+	  @ISA = ('DynaLoader');
+	  bootstrap re;
 	  install() if $on;
 	  uninstall() unless $on;
 	  next;
diff --git a/pod/perldiag.pod b/pod/perldiag.pod
index b87480e..43226e0 100644
--- a/pod/perldiag.pod
+++ b/pod/perldiag.pod
@@ -2845,6 +2845,10 @@ bad side effects.
 interpreted as a "" or a 0, but maybe it was a mistake.  To suppress this
 warning assign an initial value to your variables.
 
+=item Useless use of "re" pragma
+
+(W) You did C<use re;> without any arguments.   That isn't very useful.
+
 =item Useless use of %s in void context
 
 (W) You did something without a side effect in a context that does nothing