From: Norbert Buchmuller <norbi@nix.hu>
Date: Thu, 27 Nov 2008 04:07:01 +0000 (+0100)
Subject:  * Removed extra parens from the ON expression of JOIN (SQLA::Test now handles it... 
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=7f16e33e3707b474d44010815fff6857ddfe1828;p=dbsrgits%2FDBIx-Class-Historic.git

 * Removed extra parens from the ON expression of JOIN (SQLA::Test now handles it properly - in SQLA branch '1.50_RC-extraparens' branch). That means that all the tests pass with SQLA 1.24 and SQLA 1.50RC.
---

diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm
index c441333..3d23970 100644
--- a/lib/DBIx/Class/Storage/DBI.pm
+++ b/lib/DBIx/Class/Storage/DBI.pm
@@ -219,7 +219,7 @@ sub _recurse_from {
     } else {
       push(@sqlf, $self->_make_as($to));
     }
-    push(@sqlf, ' ON (', $self->_join_condition($on), ')');
+    push(@sqlf, ' ON ', $self->_join_condition($on));
   }
   return join('', @sqlf);
 }