From: Peter Rabbitson Date: Mon, 16 Mar 2015 14:56:53 +0000 (+0100) Subject: 'undef =>' isn't what one would want X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=7e175371f73976dae12fdebec4850832edcae580;p=dbsrgits%2FDBIx-Class-Historic.git 'undef =>' isn't what one would want --- diff --git a/lib/DBIx/Class/Storage/DBI.pm b/lib/DBIx/Class/Storage/DBI.pm index bdafe1f..26ac850 100644 --- a/lib/DBIx/Class/Storage/DBI.pm +++ b/lib/DBIx/Class/Storage/DBI.pm @@ -2219,7 +2219,7 @@ sub _insert_bulk { # scope guard my $guard = $self->txn_scope_guard; - $self->_query_start( $sql, @$proto_bind ? [[undef => '__BULK_INSERT__' ]] : () ); + $self->_query_start( $sql, @$proto_bind ? [[ {} => '__BULK_INSERT__' ]] : () ); my $sth = $self->_prepare_sth($self->_dbh, $sql); my $rv = do { if (@$proto_bind) { @@ -2233,7 +2233,7 @@ sub _insert_bulk { } }; - $self->_query_end( $sql, @$proto_bind ? [[ undef => '__BULK_INSERT__' ]] : () ); + $self->_query_end( $sql, @$proto_bind ? [[ {} => '__BULK_INSERT__' ]] : () ); $guard->commit; diff --git a/t/73oracle_blob.t b/t/73oracle_blob.t index c4ddf9a..0391d4b 100644 --- a/t/73oracle_blob.t +++ b/t/73oracle_blob.t @@ -126,7 +126,7 @@ SKIP: { { blob => "blob:$str", clob => "clob:$str" }, { from => \ "(SELECT * FROM ${q}bindtype_test${q} WHERE ${q}id${q} != ?) ${q}me${q}", - bind => [ [ undef => 12345678 ] ], + bind => [ [ {} => 12345678 ] ], } )->get_column('id')->as_query);