From: Christopher H. Laco Date: Tue, 18 Nov 2008 02:10:02 +0000 (+0000) Subject: Removed unnecessary code in get_simple: RT#40992, BUCHMULLER Norbert X-Git-Tag: v0.08003~3 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=7c0c0281b66b04902e530d2da653440cb623d13a;p=p5sagit%2FClass-Accessor-Grouped.git Removed unnecessary code in get_simple: RT#40992, BUCHMULLER Norbert --- diff --git a/Changes b/Changes index 4f8e17b..1971251 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,8 @@ Revision history for Class::Accessor::Grouped. +0.08002 Mon Nov 17 20:27:22 2008 + - Removed unnecessary code in get_simple: RT#40992, BUCHMULLER Norbert + 0.08001 Wed Jan 09 19:35:34 2008 - Fixed Makefile.PL tests setting that was killing older installs diff --git a/MANIFEST.SKIP b/MANIFEST.SKIP index 00810ee..e00c611 100644 --- a/MANIFEST.SKIP +++ b/MANIFEST.SKIP @@ -9,6 +9,8 @@ aegis.log$ \bconfig$ \bbuild$ \.DS_Store$ +\.git + # Avoid Makemaker generated and utility files. \bMakefile$ diff --git a/README b/README index df32090..2f08e17 100644 --- a/README +++ b/README @@ -105,9 +105,9 @@ METHODS Gets the value of the specified component class. __PACKAGE__->mk_group_accessors('component_class' => 'result_class'); - + $self->result_class->method(); - + ## same as $self->get_component_class('result_class')->method(); @@ -121,7 +121,7 @@ METHODS __PACKAGE__->mk_group_accessors('component_class' => 'result_class'); __PACKAGE__->result_class('MyClass'); - + $self->result_class->method(); get_super_paths diff --git a/lib/Class/Accessor/Grouped.pm b/lib/Class/Accessor/Grouped.pm index 81d778a..bdba1a8 100644 --- a/lib/Class/Accessor/Grouped.pm +++ b/lib/Class/Accessor/Grouped.pm @@ -6,7 +6,7 @@ use Class::Inspector (); use Scalar::Util (); use MRO::Compat; -our $VERSION = '0.08001'; +our $VERSION = '0.08002'; =head1 NAME @@ -243,8 +243,6 @@ name passed as an argument. =cut sub get_simple { - my ($self, $get) = @_; - return $self->{$get}; return $_[0]->{$_[1]}; } diff --git a/t/manifest.t b/t/manifest.t index 31df639..e32cdbe 100644 --- a/t/manifest.t +++ b/t/manifest.t @@ -17,6 +17,6 @@ BEGIN { ok_manifest({ exclude => ['/t/var', '/cover_db'], - filter => [qr/\.svn/, qr/cover/, qr/Build(.(PL|bat))?/, qr/_build/, qr/\.DS_Store/], + filter => [qr/\.(svn|git)/, qr/cover/, qr/Build(.(PL|bat))?/, qr/_build/, qr/\.DS_Store/], bool => 'or' });