From: Dagfinn Ilmari Mannsåker Date: Sun, 21 Dec 2014 14:42:45 +0000 (+0000) Subject: Keep calling _insert_returning for INSERT … RETURNING X-Git-Tag: v1.81_01~13 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=78536e8b84aa4fdab20f50fb2ca65d17319099af;p=dbsrgits%2FSQL-Abstract.git Keep calling _insert_returning for INSERT … RETURNING DBIC::SQLMaker::Oracle overrides this method, and its insert calls next::method, so we need keep calling the old method for the override to work. --- diff --git a/lib/SQL/Abstract.pm b/lib/SQL/Abstract.pm index 32ad7b3..3adfc01 100644 --- a/lib/SQL/Abstract.pm +++ b/lib/SQL/Abstract.pm @@ -219,7 +219,7 @@ sub insert { $sql = join " ", $self->_sqlcase('insert into'), $table, $sql; if ($options->{returning}) { - my ($s, @b) = $self->_returning ($options); + my ($s, @b) = $self->_insert_returning ($options); $sql .= $s; push @bind, @b; }