From: Matt S Trout <mst@shadowcat.co.uk>
Date: Fri, 15 Feb 2019 23:03:33 +0000 (+0000)
Subject: I have no idea why I inlined the bindval assertion but it was stupid
X-Git-Tag: v2.000000~3^2~424
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=784d3aff64c194ef306e6fb1283007c12ff1071b;p=dbsrgits%2FSQL-Abstract.git

I have no idea why I inlined the bindval assertion but it was stupid
---

diff --git a/lib/SQL/Abstract.pm b/lib/SQL/Abstract.pm
index fa25141..fee1e3f 100644
--- a/lib/SQL/Abstract.pm
+++ b/lib/SQL/Abstract.pm
@@ -861,9 +861,7 @@ sub _expand_expr_hashpair {
     my ($sql, @bind) = @$literal;
     if ($self->{bindtype} eq 'columns') {
       for (@bind) {
-        if (!defined $_ || ref($_) ne 'ARRAY' || @$_ != 2) {
-          puke "bindtype 'columns' selected, you need to pass: [column_name => bind_value]"
-        }
+        $self->_assert_bindval_matches_bindtype($_);
       }
     }
     return +{ -literal => [ $self->_quote($k).' '.$sql, @bind ] };