From: Peter Rabbitson <ribasushi@cpan.org>
Date: Fri, 26 Sep 2014 10:15:25 +0000 (+0200)
Subject: Turn the CXSA error TODOs into hard skips
X-Git-Tag: v0.10011~4
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=76427bb1ddcfc2374ae9eb615855adf19069a55b;p=p5sagit%2FClass-Accessor-Grouped.git

Turn the CXSA error TODOs into hard skips

I won't be able to get to fix this any time soon, and besides the real fix
is to provide a die handler. Since this had some false positives previously
might as well skip it alogether
---

diff --git a/t/accessors_ro.t b/t/accessors_ro.t
index 708e70c..33d3f38 100644
--- a/t/accessors_ro.t
+++ b/t/accessors_ro.t
@@ -3,7 +3,6 @@ use Test::Exception;
 use strict;
 use warnings;
 no warnings 'once';
-use Config;
 use lib 't/lib';
 
 # we test the pure-perl versions only, but allow overrides
@@ -84,15 +83,12 @@ for my $name (sort keys %$test_accessors) {
     : qr/$name(:?_accessor)?\Q' cannot alter its value (read-only attribute of class AccessorGroupsRO)/
   ;
 
-  {
-    local $TODO = "Class::XSAccessor emits broken error messages on 5.10 or -DDEBUGGING 5.8"
-      if (
-        $test_accessors->{$name}{is_xs}
-          and
-        $] < '5.011'
-          and
-        ( $] > '5.009' or $Config{config_args} =~ /DEBUGGING/ )
-      );
+  SKIP: {
+    skip "Class::XSAccessor emits broken error messages on 5.10 and earlier", 1 if (
+      $test_accessors->{$name}{is_xs}
+        and
+      $] < '5.011'
+    );
 
     # die on set via name/alias
     throws_ok {
diff --git a/t/accessors_wo.t b/t/accessors_wo.t
index 9fc2bcd..e801118 100644
--- a/t/accessors_wo.t
+++ b/t/accessors_wo.t
@@ -3,7 +3,6 @@ use Test::Exception;
 use strict;
 use warnings;
 no warnings 'once';
-use Config;
 use lib 't/lib';
 
 # we test the pure-perl versions only, but allow overrides
@@ -82,15 +81,12 @@ for my $name (sort keys %$test_accessors) {
   ;
 
   # die on get via name/alias
-  {
-    local $TODO = "Class::XSAccessor emits broken error messages on 5.10 or -DDEBUGGING 5.8"
-      if (
-        $test_accessors->{$name}{is_xs}
-          and
-        $] < '5.011'
-          and
-        ( $] > '5.009' or $Config{config_args} =~ /DEBUGGING/ )
-      );
+  SKIP: {
+    skip "Class::XSAccessor emits broken error messages on 5.10 and earlier", 1 if (
+      $test_accessors->{$name}{is_xs}
+        and
+      $] < '5.011'
+    );
 
     throws_ok {
       $obj->$name;