From: Steve Peters <steve@fisharerojo.org>
Date: Sun, 23 Jul 2006 13:46:05 +0000 (+0000)
Subject: The rest of the changes for Sys-Syslog-0.17 which my new patch no
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=74c4de31ffa942581a6c745b8cb052420394373f;p=p5sagit%2Fp5-mst-13.2.git

The rest of the changes for Sys-Syslog-0.17 which my new patch no
longer automatically "p4 edits" for me.

p4raw-id: //depot/perl@28611
---

diff --git a/ext/Sys/Syslog/Changes b/ext/Sys/Syslog/Changes
index abc07df..585eca4 100644
--- a/ext/Sys/Syslog/Changes
+++ b/ext/Sys/Syslog/Changes
@@ -1,5 +1,13 @@
 Revision history for Sys-Syslog
 
+0.17 -- 2006.07.23 -- Sebastien Aperghis-Tramoni (SAPER)
+        [BUGFIX] CPAN-RT#20622, #20164: Fixed path handling in connect_unix().
+        [CODE] Renamed some variables ($that is not a valid name), and removed 
+        some dead code. 
+        [CODE] Actually added the macros from Mac OS X that was announced in 
+        the 0.14 version.
+        [DOC] CPAN-RT#20545: Rewrote the documentation about setlogksock().
+
 0.16 -- 2006.06.20 -- Sebastien Aperghis-Tramoni (SAPER)
         [BUGFIX] Perl-RT#20557: Save errno before trying to connect.
         [FEATURE] Perl-RT#35406: Applied the patch proposed by Keisuke Hirata 
@@ -40,8 +48,8 @@ Revision history for Sys-Syslog
         use INADDR_LOOPBACK.
         [CODE] Merged blead@26772: $host needs to stay in case the user sets it.
         [CODE] Merged blead@26773: check that $syslog_path is a socket.
-        [TESTS] CPAN-RT#16980 (Alan Burlison): Sys::Syslog blows up rather 
-        spectacularly on Solaris. Corrected by previous patches. 
+        [TESTS] CPAN-RT#16980: Sys::Syslog blows up rather spectacularly on 
+        Solaris. Corrected by previous patches. 
         [TESTS] CPAN-RT#16974: Failed test in t/podspell. This test is now skipped.
 
 0.12 -- 2006.01.07 -- Sebastien Aperghis-Tramoni (SAPER)
diff --git a/ext/Sys/Syslog/Makefile.PL b/ext/Sys/Syslog/Makefile.PL
index 966b011..3cb0c64 100644
--- a/ext/Sys/Syslog/Makefile.PL
+++ b/ext/Sys/Syslog/Makefile.PL
@@ -36,13 +36,32 @@ if (-S "/dev/log" and -w "/dev/log") {
 }
 
 if(eval {require ExtUtils::Constant; 1}) {
-    my @names = (qw( LOG_ALERT LOG_AUTH LOG_AUTHPRIV LOG_CONS LOG_CRIT LOG_CRON
-                     LOG_DAEMON LOG_DEBUG LOG_EMERG LOG_ERR LOG_FACMASK LOG_FTP
-                     LOG_INFO LOG_KERN LOG_LFMT LOG_LOCAL0 LOG_LOCAL1 LOG_LOCAL2
-                     LOG_LOCAL3 LOG_LOCAL4 LOG_LOCAL5 LOG_LOCAL6 LOG_LOCAL7 LOG_LPR
-                     LOG_MAIL LOG_NDELAY LOG_NEWS LOG_NFACILITIES LOG_NOTICE
-                     LOG_NOWAIT LOG_ODELAY LOG_PERROR LOG_PID LOG_PRIMASK LOG_SYSLOG
-                     LOG_USER LOG_UUCP LOG_WARNING),
+    my @names = (
+            # levels
+            qw(
+                LOG_ALERT LOG_CRIT LOG_DEBUG LOG_EMERG LOG_ERR 
+                LOG_INFO LOG_NOTICE LOG_WARNING
+            ), 
+
+            # facilities
+            qw(
+                LOG_AUTH LOG_AUTHPRIV LOG_CRON LOG_DAEMON LOG_FTP
+                LOG_INSTALL LOG_KERN LOG_LAUNCHD LOG_LFMT LOG_LOCAL0 
+                LOG_LOCAL1 LOG_LOCAL2 LOG_LOCAL3 LOG_LOCAL4 LOG_LOCAL5 
+                LOG_LOCAL6 LOG_LOCAL7 LOG_LPR LOG_MAIL LOG_NETINFO 
+                LOG_NEWS LOG_RAS LOG_REMOTEAUTH LOG_SYSLOG LOG_USER LOG_UUCP 
+            ), 
+
+            # options
+            qw(
+                LOG_CONS LOG_PID LOG_NDELAY LOG_NOWAIT LOG_ODELAY LOG_PERROR 
+            ), 
+
+            # others macros
+            qw(
+                LOG_FACMASK LOG_NFACILITIES LOG_PRIMASK 
+            ), 
+
            { name => "_PATH_LOG", type => "PV", default => [ "PV", qq("$_PATH_LOG") ] },
     );
 
diff --git a/ext/Sys/Syslog/README b/ext/Sys/Syslog/README
index e8c0397..ae3a8b9 100644
--- a/ext/Sys/Syslog/README
+++ b/ext/Sys/Syslog/README
@@ -25,7 +25,6 @@ INSTALLATION
     but is likely to run on many more:
 
       - Linux 2.6, gcc 3.4.1
-      - FreeBSD 4.7, gcc 2.95.4
       - FreeBSD 6.0, gcc 3.4.4
       - Mac OS X 10.4, gcc 4.0.1
 
@@ -35,10 +34,10 @@ INSTALLATION
 
       - Perl 5.6.2 i686-linux (custom build)
       - Perl 5.8.5 i386-linux-thread-multi (vendor build)
-      - Perl 5.6.1 i386-freebsd (custom build)
-      - Perl 5.8.7 i386-freebsd (custom build)
+      - Perl 5.8.7 i386-linux (custom build)
       - Perl 5.8.8 i386-freebsd-64int (custom build)
-      - Perl 5.8.6 darwin-thread-multi-2level (PowerPC, x86) (vendor build)
+      - Perl 5.8.8 i386-linux (custom build)
+      - Perl 5.8.6 darwin-thread-multi-2level (PowerPC) (vendor build)
 
     See also the corresponding CPAN Testers page:
         http://testers.cpan.org/show/Sys-Syslog.html
diff --git a/ext/Sys/Syslog/t/syslog.t b/ext/Sys/Syslog/t/syslog.t
index 76353e9..6eae2b6 100755
--- a/ext/Sys/Syslog/t/syslog.t
+++ b/ext/Sys/Syslog/t/syslog.t
@@ -44,7 +44,7 @@ BEGIN { $tests += 1 }
 # check the diagnostics
 # setlogsock()
 eval { setlogsock() };
-like( $@, qr/^Invalid argument passed to setlogsock; must be 'stream', 'unix', 'native', 'tcp', 'udp' or 'inet'/, 
+like( $@, qr/^Invalid argument passed to setlogsock/, 
     "calling setlogsock() with no argument" );
 
 BEGIN { $tests += 3 }
@@ -61,11 +61,6 @@ eval { syslog('') };
 like( $@, qr/^syslog: expecting argument \$format/, 
     "calling syslog() with one empty argument" );
 
-BEGIN { $tests += 1 }
-# setlogsock()
-eval { setlogsock() };
-like( $@, qr/^Invalid argument passed to setlogsock; must be 'stream', 'unix', 'native', 'tcp', 'udp' or 'inet'/, 
-    "calling setlogsock() with no argument" );
 
 my $test_string = "uid $< is testing Perl $] syslog(3) capabilities";
 my $r = 0;