From: Rafael Kitover <rkitover@cpan.org>
Date: Thu, 17 Dec 2009 12:34:20 +0000 (+0000)
Subject: minor changes
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=748eb62028de5636c4c25d2fa94ebb677ea8282a;p=dbsrgits%2FDBIx-Class-Historic.git

minor changes
---

diff --git a/lib/DBIx/Class/Storage/DBI/ADO.pm b/lib/DBIx/Class/Storage/DBI/ADO.pm
index 8a0fa68..e457b96 100644
--- a/lib/DBIx/Class/Storage/DBI/ADO.pm
+++ b/lib/DBIx/Class/Storage/DBI/ADO.pm
@@ -26,7 +26,8 @@ sub _rebless {
   }
 }
 
-# set cursor type here, if necessary
+# Here I was just experimenting with ADO cursor types, left in as a comment in
+# case you want to as well. See the DBD::ADO docs.
 #sub _dbh_sth {
 #  my ($self, $dbh, $sql) = @_;
 #
diff --git a/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm b/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm
index 5f2330a..85898fa 100644
--- a/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm
+++ b/lib/DBIx/Class/Storage/DBI/ADO/Microsoft_SQL_Server.pm
@@ -42,6 +42,7 @@ sub bind_attribute_by_data_type {
 }
 
 # approximate
+# XXX needs to support varchar(max) and varbinary(max)
 sub _mssql_max_data_type_representation_size_in_bytes {
   my $self = shift;
 
@@ -65,6 +66,7 @@ sub _mssql_max_data_type_representation_size_in_bytes {
     money => 100,
     float => 100,
     real => 100,
+    uniqueidentifier => 100,
     ntext => $blob_max,
     text => $blob_max,
     image => $blob_max,