From: gfx <gfuji@cpan.org>
Date: Wed, 23 Sep 2009 04:10:25 +0000 (+0900)
Subject: Fix type constraint issue
X-Git-Tag: 0.33~8
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=73766a27db7dcd127e0397d83186dadfcda398a9;p=gitmo%2FMouse.git

Fix type constraint issue
---

diff --git a/lib/Mouse/Util/TypeConstraints.pm b/lib/Mouse/Util/TypeConstraints.pm
index a11a478..8cbcc26 100644
--- a/lib/Mouse/Util/TypeConstraints.pm
+++ b/lib/Mouse/Util/TypeConstraints.pm
@@ -29,7 +29,7 @@ sub message (&) {
     return(message => $_[0])
 }
 
-sub from { @_ }
+sub from    { @_ }
 sub via (&) { $_[0] }
 
 BEGIN {
@@ -37,16 +37,14 @@ BEGIN {
     %TYPE = (
         Any        => sub { 1 },
         Item       => sub { 1 },
-        Bool       => sub {
-            !defined($_[0]) || $_[0] eq "" || "$_[0]" eq '1' || "$_[0]" eq '0'
-        },
+
+        Bool       => sub { $_[0] ? $_[0] eq '1' : 1 },
         Undef      => sub { !defined($_[0]) },
         Defined    => sub { defined($_[0]) },
         Value      => sub { defined($_[0]) && !ref($_[0]) },
         Num        => sub { !ref($_[0]) && looks_like_number($_[0]) },
         Int        => sub { defined($_[0]) && !ref($_[0]) && $_[0] =~ /^-?[0-9]+$/ },
         Str        => sub { defined($_[0]) && !ref($_[0]) },
-        ClassName  => sub { Mouse::is_class_loaded($_[0]) },
         Ref        => sub { ref($_[0]) },
 
         ScalarRef  => sub { ref($_[0]) eq 'SCALAR' },
@@ -63,9 +61,15 @@ BEGIN {
         },
 
         Object     => sub { blessed($_[0]) && blessed($_[0]) ne 'Regexp' },
+
+        ClassName  => sub { Mouse::Util::is_class_loaded($_[0]) },
+        RoleName   => sub { (Mouse::Util::class_of($_[0]) || return 0)->isa('Mouse::Meta::Role') },
     );
     while (my ($name, $code) = each %TYPE) {
-        $TYPE{$name} = Mouse::Meta::TypeConstraint->new( _compiled_type_constraint => $code, name => $name );
+        $TYPE{$name} = Mouse::Meta::TypeConstraint->new(
+            name                      => $name,
+            _compiled_type_constraint => $code,
+        );
     }
 
     sub optimized_constraints { \%TYPE }
@@ -76,8 +80,27 @@ BEGIN {
 }
 
 sub type {
-    my $pkg = caller(0);
-    my($name, %conf) = @_;
+    my $name;
+    my %conf;
+
+    if(@_ == 1 && ref $_[0]){ # type { where => ... }
+        %conf = %{$_[0]};
+    }
+    elsif(@_ == 2 && ref $_[1]){ # type $name => { where => ... }*
+        $name = $_[0];
+        %conf = %{$_[1]};
+    }
+    elsif(@_ % 2){ # odd number of arguments
+        $name = shift;
+        %conf = @_;
+    }
+    else{
+        %conf = @_;
+    }
+
+    $name = '__ANON__' if !defined $name;
+
+    my $pkg = caller;
 
     if ($TYPE{$name} && $TYPE_SOURCE{$name} ne $pkg) {
         Carp::croak "The type constraint '$name' has already been created in $TYPE_SOURCE{$name} and cannot be created again in $pkg";
@@ -105,23 +128,32 @@ sub type {
 }
 
 sub subtype {
-    my $pkg = caller;
-
     my $name;
     my %conf;
 
-    if(@_ % 2){ # odd number of arguments
+    if(@_ == 1 && ref $_[0]){ # type { where => ... }
+        %conf = %{$_[0]};
+    }
+    elsif(@_ == 2 && ref $_[1]){ # type $name => { where => ... }*
+        $name = $_[0];
+        %conf = %{$_[1]};
+    }
+    elsif(@_ % 2){ # odd number of arguments
         $name = shift;
         %conf = @_;
     }
     else{
         %conf = @_;
-        $name = $conf{name} || '__ANON__';
     }
 
+    $name = '__ANON__' if !defined $name;
+
+    my $pkg = caller;
+
+
     if ($TYPE{$name} && $TYPE_SOURCE{$name} ne $pkg) {
         Carp::croak "The type constraint '$name' has already been created in $TYPE_SOURCE{$name} and cannot be created again in $pkg";
-    };
+    }
     my $constraint = delete $conf{where};
     my $as_constraint = find_or_create_isa_type_constraint(delete $conf{as} || 'Any');
 
diff --git a/t/050_metaclasses/011_init_meta.t b/t/050_metaclasses/011_init_meta.t
index 9c47c78..9755f85 100644
--- a/t/050_metaclasses/011_init_meta.t
+++ b/t/050_metaclasses/011_init_meta.t
@@ -7,10 +7,7 @@ use Test::More tests => 4;
 
 use Mouse ();
 
-
-{ package Foo; }
-
-my $meta = Mouse::init_meta('Foo');
+my $meta = Mouse->init_meta(for_class => 'Foo');
 
 ok( Foo->isa('Mouse::Object'), '... Foo isa Mouse::Object');
 isa_ok( $meta, 'Mouse::Meta::Class' );
diff --git a/t/200_examples/004_example_w_DCS.t b/t/200_examples/004_example_w_DCS.t
index 00e8dce..58cd3e7 100644
--- a/t/200_examples/004_example_w_DCS.t
+++ b/t/200_examples/004_example_w_DCS.t
@@ -30,11 +30,12 @@ use Test::Exception;
 
     # define your own type ...
     type( 'HashOfArrayOfObjects',
+        {
         where => IsHashRef(
             -keys   => HasLength,
             -values => IsArrayRef(IsObject)
         )
-    );
+    } );
 
     has 'bar' => (
         is  => 'rw',
@@ -44,7 +45,7 @@ use Test::Exception;
     # inline the constraints as anon-subtypes
     has 'baz' => (
         is  => 'rw',
-        isa => subtype( as => 'ArrayRef', where => IsArrayRef(IsInt) ),
+        isa => subtype( { as => 'ArrayRef', where => IsArrayRef(IsInt) } ),
     );
 
     package Bar;
@@ -82,7 +83,6 @@ dies_ok {
     $foo->bar({ foo => [ 1, 2, 3 ] });
 } '... validation failed correctly';
 
-
 dies_ok {
     $foo->baz([ "foo" ]);
 } '... validation failed correctly';
@@ -90,3 +90,4 @@ dies_ok {
 dies_ok {
     $foo->baz({});
 } '... validation failed correctly';
+