From: gfx <gfuji@cpan.org>
Date: Sat, 5 Sep 2009 07:33:08 +0000 (+0900)
Subject: Remove an unnecessary NULL check, which is already checked other places
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=72df79cfe3e47a2c10d5ec5cec73128097bea176;p=p5sagit%2Fp5-mst-13.2.git

Remove an unnecessary NULL check, which is already checked other places

Signed-off-by: Yves Orton <demerphq@gemini.(none)>
---

diff --git a/pp_hot.c b/pp_hot.c
index a78f022..61d8b43 100644
--- a/pp_hot.c
+++ b/pp_hot.c
@@ -2869,8 +2869,10 @@ try_autoload:
 	    PL_curcopdb = NULL;
 	}
 	/* Do we need to open block here? XXXX */
-	if (CvXSUB(cv)) /* XXX this is supposed to be true */
-	    (void)(*CvXSUB(cv))(aTHX_ cv);
+
+	/* CvXSUB(cv) must not be NULL because newXS() refuses NULL xsub address */
+	assert(CvXSUB(cv));
+	CALL_FPTR(CvXSUB(cv))(aTHX_ cv);
 
 	/* Enforce some sanity in scalar context. */
 	if (gimme == G_SCALAR && ++markix != PL_stack_sp - PL_stack_base ) {