From: Peter Rabbitson <ribasushi@cpan.org>
Date: Fri, 25 Jan 2013 02:26:06 +0000 (+0100)
Subject: Revert 344f761c - this was a stupid idea
X-Git-Tag: v0.08206~16
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=728f32b5;p=dbsrgits%2FDBIx-Class.git

Revert 344f761c - this was a stupid idea

Way too many failures, maked CPANTesters output unusable.
Extracted and submitted as DBI RT#82942 instead
---

diff --git a/t/52leaks.t b/t/52leaks.t
index 27e4e22..f1d11af 100644
--- a/t/52leaks.t
+++ b/t/52leaks.t
@@ -410,13 +410,16 @@ for my $moniker ( keys %{DBICTest::Schema->source_registrations || {}} ) {
 # half of it is in XS no leaktracer sees it, and Devel::FindRef is equally
 # stumped when trying to trace the origin. The problem is:
 #
-# $cond_object --> result_source --> schema --> storage --> $dbh --> {cached_kids}
+# $cond_object --> result_source --> schema --> storage --> $dbh --> {CachedKids}
 #          ^                                                           /
 #           \-------- bound value on prepared/cached STH  <-----------/
 #
-if ( my $r = $weak_registry->{'basic leaky_resultset_cond'}{weakref} ) {
-  ok(! defined $r, 'Self-referential RS conditions no longer leak!')
-    or $r->result_source(undef);
+{
+  local $TODO = 'This fails intermittently - see RT#82942';
+  if ( my $r = $weak_registry->{'basic leaky_resultset_cond'}{weakref} ) {
+    ok(! defined $r, 'Self-referential RS conditions no longer leak!')
+      or $r->result_source(undef);
+  }
 }
 
 assert_empty_weakregistry ($weak_registry);