From: Rafael Kitover <rkitover@cpan.org>
Date: Sat, 14 Nov 2009 09:27:29 +0000 (+0000)
Subject: fix the large column list test for ADO/MSSQL, now passes
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=7282bf38455fcfc56d663c95b43d26d69b40b70f;p=dbsrgits%2FDBIx-Class-Historic.git

fix the large column list test for ADO/MSSQL, now passes
---

diff --git a/Changes b/Changes
index 34f8303..1cdfefe 100644
--- a/Changes
+++ b/Changes
@@ -18,7 +18,7 @@ Revision history for DBIx::Class
              connecting to an older Sybase and/or via FreeTDS
           - bulk API support for populate()
         - Transaction support for MSSQL via DBD::Sybase
-        - Preliminary (read not very good) support for MSSQL via DBD::ADO
+        - Preliminary support for MSSQL via DBD::ADO
         - Add is_paged method to DBIx::Class::ResultSet so that we can
           check that if we want a pager
         - Skip versioning test on really old perls lacking Time::HiRes
diff --git a/t/747mssql_ado.t b/t/747mssql_ado.t
index d86e4e1..7981c78 100644
--- a/t/747mssql_ado.t
+++ b/t/747mssql_ado.t
@@ -11,7 +11,7 @@ my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_MSSQL_ADO_${_}" } qw/DSN USER PAS
 plan skip_all => 'Set $ENV{DBICTEST_MSSQL_ADO_DSN}, _USER and _PASS to run this test'
   unless ($dsn && $user);
 
-plan tests => 11;
+plan tests => 12;
 
 my $schema = DBICTest::Schema->connect($dsn, $user, $pass);
 $schema->storage->ensure_connected;
@@ -39,15 +39,13 @@ ok($new->artistid > 0, 'Auto-PK worked');
 my $found = $schema->resultset('Artist')->search({ name => 'foo' })->first;
 is $found->artistid, $new->artistid, 'search works';
 
-# try a select with a big column list
-TODO: {
-  local $TODO = 'select with a big column list does not work';
-
-  $found = $schema->resultset('Artist')->search({ name => 'foo' }, {
-    select => ['name', map "'foo' foo_$_", 0..50]
-  })->first;
-  is $found->artistid, $new->artistid, 'select with big column list';
-}
+# test large column list in select
+$found = $schema->resultset('Artist')->search({ name => 'foo' }, {
+  select => ['artistid', 'name', map "'foo' foo_$_", 0..50],
+  as     => ['artistid', 'name', map       "foo_$_", 0..50],
+})->first;
+is $found->artistid, $new->artistid, 'select with big column list';
+is $found->get_column('foo_50'), 'foo', 'last item in big column list';
 
 # create a few more rows
 for (1..6) {