From: Peter Rabbitson Date: Mon, 22 Jul 2013 03:06:19 +0000 (+0200) Subject: Install EU::CB in a separate step as to not tickle an old CPAN bug X-Git-Tag: v0.08260~197 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=726501ac7b53da828fc360c2ddcd0bd3e12e56bb;p=dbsrgits%2FDBIx-Class.git Install EU::CB in a separate step as to not tickle an old CPAN bug Older CPAN.pm had a problem with the circular dependency resolution firing erroneously *after* everything was successfully installed, e.g.: https://s3.amazonaws.com/archive.travis-ci.org/jobs/9336470/log.txt (scroll to the end) --- diff --git a/maint/travis-ci_scripts/30_before_script.bash b/maint/travis-ci_scripts/30_before_script.bash index a1968b4..3428b87 100755 --- a/maint/travis-ci_scripts/30_before_script.bash +++ b/maint/travis-ci_scripts/30_before_script.bash @@ -45,9 +45,11 @@ if [[ "$CLEANTEST" = "true" ]]; then # possible, mainly to catch "but X is perl core" mistakes # So instead we still use our stock (possibly old) CPAN, and add some # handholding - CPAN_is_sane || \ - run_or_err "Pre-installing ExtUtils::MakeMaker and Module::Build" \ - "cpan ExtUtils::MakeMaker Module::Build" + if ! CPAN_is_sane ; then + for m in ExtUtils::MakeMaker ExtUtils::CBuilder Module::Build ; do + run_or_err "Pre-installing $m" "cpan $m" + done + fi if ! perl -MModule::Build -e 1 &> /dev/null ; then echo_err -e "Module::Build installation failed\n$LASTOUT"