From: gfx <gfuji@cpan.org>
Date: Tue, 3 Nov 2009 02:51:51 +0000 (+0900)
Subject: Skip  BUILDALL in the default constructor, and DEMOLISHALL in the default destructor:
X-Git-Tag: 0.40_06~39
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6ff81d81df833c5faa820ab7148df1c7d58d24d3;p=gitmo%2FMouse.git

Skip  BUILDALL in the default constructor, and DEMOLISHALL in the default destructor:

This is because generated (optimized) constructors/destructors do not call them. Don't modify BUILDALL and DEMOLISHALL, anyway.
---

diff --git a/lib/Mouse/Object.pm b/lib/Mouse/Object.pm
index 604986d..5f09e0a 100644
--- a/lib/Mouse/Object.pm
+++ b/lib/Mouse/Object.pm
@@ -8,9 +8,20 @@ sub new {
 
     my $args = $class->BUILDARGS(@_);
 
-    my $instance = Mouse::Meta::Class->initialize($class)->new_object($args);
-    $instance->BUILDALL($args);
-    return $instance;
+    my $meta = Mouse::Meta::Class->initialize($class);
+    my $self = $meta->new_object($args);
+
+    # BUILDALL
+    if( $self->can('BUILD') ) {
+        for my $class (reverse $meta->linearized_isa) {
+            my $build = Mouse::Util::get_code_ref($class, 'BUILD')
+                || next;
+
+            $self->$build($args);
+        }
+    }
+
+    return $self;
 }
 
 sub BUILDARGS {
@@ -30,12 +41,27 @@ sub BUILDARGS {
 sub DESTROY {
     my $self = shift;
 
+    return unless $self->can('DEMOLISH'); # short circuit
+
     local $?;
 
     my $e = do{
         local $@;
         eval{
-            $self->DEMOLISHALL();
+
+            # DEMOLISHALL
+
+            # We cannot count on being able to retrieve a previously made
+            # metaclass, _or_ being able to make a new one during global
+            # destruction. However, we should still be able to use mro at
+            # that time (at least tests suggest so ;)
+
+            foreach my $class (@{ Mouse::Util::get_linear_isa(ref $self) }) {
+                my $demolish = Mouse::Util::get_code_ref($class, 'DEMOLISH')
+                    || next;
+
+                $self->$demolish();
+            }
         };
         $@;
     };