From: Chris Williams Date: Wed, 21 Apr 2010 08:47:27 +0000 (+0100) Subject: Make the Module::CoreList function API consistent X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6d7c3a122b88499ed48224f66cf9462018649bb2;p=p5sagit%2Fp5-mst-13.2.git Make the Module::CoreList function API consistent Some functions could only be called with class method type syntax. Other functions could only be called with normal sub syntax. This makes the API consistent, functions can be called with either syntax. --- diff --git a/dist/Module-CoreList/lib/Module/CoreList.pm b/dist/Module-CoreList/lib/Module/CoreList.pm index 57d8ffc..911e9d6 100644 --- a/dist/Module-CoreList/lib/Module/CoreList.pm +++ b/dist/Module-CoreList/lib/Module/CoreList.pm @@ -100,7 +100,9 @@ END { sub first_release_raw { - my ($discard, $module, $version) = @_; + my $module = shift; + $module = shift if $module->isa(__PACKAGE__); + my $version = shift; my @perls = $version ? grep { exists $version{$_}{ $module } && @@ -123,8 +125,8 @@ sub first_release { } sub find_modules { - my $discard = shift; my $regex = shift; + $regex = shift if $regex->isa(__PACKAGE__); my @perls = @_; @perls = keys %version unless @perls; @@ -138,13 +140,17 @@ sub find_modules { } sub find_version { - my ($class, $v) = @_; + my $class = shift; + $class = shift if $class->isa(__PACKAGE__); + my $v = shift; return $version{$v} if defined $version{$v}; return undef; } sub is_deprecated { - my ($module, $perl_version) = @_; + my $module = shift; + $module = shift if $module->isa(__PACKAGE__); + my $perl_version = shift; $perl_version ||= $]; return unless $module && exists $deprecated{$perl_version}{$module}; return $deprecated{$perl_version}{$module};