From: Brandon Black <blblack@gmail.com>
Date: Thu, 29 Mar 2007 14:11:00 +0000 (+0000)
Subject: import latest changes to DBIC::Storage::DBI to-be-deprecated columns_info_for to... 
X-Git-Tag: 0.03999_01~19
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6ce0bcc3cab1d89393eb37486a5cd4c2b99da8cc;p=dbsrgits%2FDBIx-Class-Schema-Loader.git

import latest changes to DBIC::Storage::DBI to-be-deprecated columns_info_for to our variant
---

diff --git a/lib/DBIx/Class/Schema/Loader/DBI.pm b/lib/DBIx/Class/Schema/Loader/DBI.pm
index e957a22..5383a03 100644
--- a/lib/DBIx/Class/Schema/Loader/DBI.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI.pm
@@ -197,18 +197,12 @@ sub _columns_info_for {
         $table = $self->db_schema . $self->{_namesep} . $table;
     }
     my %result;
-    my $sth = $dbh->prepare("SELECT * FROM $table WHERE 1=0");
+    my $sth = $dbh->prepare($self->schema->storage->sql_maker->select($table, undef, \'1 = 0'));
     $sth->execute;
     my @columns = @{$sth->{NAME_lc}};
     for my $i ( 0 .. $#columns ){
         my %column_info;
-        my $type_num = $sth->{TYPE}->[$i];
-        my $type_name;
-        if(defined $type_num && $dbh->can('type_info')) {
-            my $type_info = $dbh->type_info($type_num);
-            $type_name = $type_info->{TYPE_NAME} if $type_info;
-        }
-        $column_info{data_type} = $type_name ? $type_name : $type_num;
+        $column_info{data_type} = $sth->{TYPE}->[$i];
         $column_info{size} = $sth->{PRECISION}->[$i];
         $column_info{is_nullable} = $sth->{NULLABLE}->[$i] ? 1 : 0;
 
@@ -219,11 +213,22 @@ sub _columns_info_for {
 
         $result{$columns[$i]} = \%column_info;
     }
+    $sth->finish;
+
+    foreach my $col (keys %result) {
+        my $colinfo = $result{$col};
+        my $type_num = $colinfo->{data_type};
+        my $type_name;
+        if(defined $type_num && $dbh->can('type_info')) {
+            my $type_info = $dbh->type_info($type_num);
+            $type_name = $type_info->{TYPE_NAME} if $type_info;
+            $colinfo->{data_type} = $type_name if $type_name;
+        }
+    }
 
     return \%result;
 }
 
-
 =head1 SEE ALSO
 
 L<DBIx::Class::Schema::Loader>