From: Nicholas Clark Date: Tue, 2 Jan 2007 14:55:29 +0000 (+0000) Subject: Note that the examples for the structure copying bug example are no X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6c9e42f72545c13a658eedd9d691686aeeea23f4;p=p5sagit%2Fp5-mst-13.2.git Note that the examples for the structure copying bug example are no longer relevant because of the XPVGV re-ordering. p4raw-id: //depot/perl@29662 --- diff --git a/sv.c b/sv.c index 6dd53b7..a98c70b 100644 --- a/sv.c +++ b/sv.c @@ -1178,7 +1178,9 @@ Perl_sv_upgrade(pTHX_ register SV *sv, svtype new_type) (In fact, GP ends up pointing at a previous GP structure, because the principle cause of the padding in XPVMG getting garbage is a copy of - sizeof(XPVMG) bytes from a XPVGV structure in sv_unglob) + sizeof(XPVMG) bytes from a XPVGV structure in sv_unglob. Right now + this happens to be moot because XPVGV has been re-ordered, with GP + no longer after STASH) So we are careful and work out the size of used parts of all the structures. */