From: Jesse Luehrs Date: Thu, 16 Jun 2011 16:51:51 +0000 (-0500) Subject: if we aren't calling _inline_return_value, none of this is necessary X-Git-Tag: 2.0102~11 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6c19d3ee73a6b88da3bf877e8d0f6b649ed9c990;p=gitmo%2FMoose.git if we aren't calling _inline_return_value, none of this is necessary --- diff --git a/lib/Moose/Meta/Method/Accessor/Native/Hash/accessor.pm b/lib/Moose/Meta/Method/Accessor/Native/Hash/accessor.pm index 695f893..3632eec 100644 --- a/lib/Moose/Meta/Method/Accessor/Native/Hash/accessor.pm +++ b/lib/Moose/Meta/Method/Accessor/Native/Hash/accessor.pm @@ -41,12 +41,6 @@ sub _generate_method { $self->_inline_check_lazy($inv, '$type_constraint', '$type_coercion', '$type_message'), # get 'if (@_ == 1) {', - # XXX: ugh, this is a hack - we need _return_value from - # both ::set and ::get, but we can only have one, so we pick - # the one from ::set and munge it to work for the ::get case - # this should be fixed in a better way - # -doy - 'my @keys_idx = 0;', $self->_inline_check_var_is_valid_key('$_[0]'), $slot_access . '->{$_[0]}', '}',