From: Dave Rolsky <autarch@urth.org>
Date: Sat, 24 Nov 2007 18:04:31 +0000 (+0000)
Subject: Some small test improvements.
X-Git-Tag: 0.01~6
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6b059c7811f9345c89ea07c4ebb63ad6310d7932;hp=87e56db4ae9933b2c4b10611c9d2a27c7f1560d2;p=gitmo%2FMooseX-ClassAttribute.git

Some small test improvements.
---

diff --git a/t/lib/SharedTests.pm b/t/lib/SharedTests.pm
index 3d9c242..430fb1f 100644
--- a/t/lib/SharedTests.pm
+++ b/t/lib/SharedTests.pm
@@ -35,9 +35,9 @@ use Test::More tests => 9;
 
     sub BUILD
     {
-        my $class = shift;
+        my $self = shift;
 
-        $class->ObjectCount( $class->ObjectCount() + 1 );
+        $self->ObjectCount( $self->ObjectCount() + 1 );
     }
 }
 
@@ -65,10 +65,10 @@ sub run_tests
     }
 
     {
-        my $hca3 = HasClassAttribute->new( ObjectCount => 20 );
-        is( $hca3->ObjectCount(), 3,
-            'class attributes are not affected by constructor params' );
-        is( HasClassAttribute->ObjectCount(), 3,
+        eval { HasClassAttribute->new( ObjectCount => 20 ) };
+        like( $@, qr/\QCannot set a class attribute via the constructor (ObjectCount)/,
+              'passing a class attribute to the constructor throws an error' );
+        is( HasClassAttribute->ObjectCount(), 2,
             'class attributes are not affected by constructor params' );
     }
 
@@ -77,7 +77,9 @@ sub run_tests
 
         HasClassAttribute->WeakAttribute($object);
 
-        ok( isweak( $HasClassAttribute::__ClassAttribute{WeakAttribute} ),
+        undef $object;
+
+        ok( ! defined HasClassAttribute->WeakAttribute(),
             'weak class attributes are weak' );
     }
 }