From: Peter Rabbitson Date: Mon, 13 Sep 2010 00:17:08 +0000 (+0200) Subject: Remove duplicate test (same as end of t/storage/error.t) X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=68fe9141d8c2d8ca64a0bc6452b2ffbf36d28512;p=dbsrgits%2FDBIx-Class-Historic.git Remove duplicate test (same as end of t/storage/error.t) --- diff --git a/t/34exception_action.t b/t/34exception_action.t index f76a100..0fec11a 100644 --- a/t/34exception_action.t +++ b/t/34exception_action.t @@ -5,8 +5,6 @@ use Test::More; use lib qw(t/lib); use DBICTest; -plan tests => 9; - # Set up the "usual" sqlite for DBICTest my $schema = DBICTest->init_schema; @@ -70,13 +68,4 @@ eval { $schema->storage->throw_exception('floob') }; like($@, qr/DBICTest::Exception is handling this: floob/); -# This usage is a bit unusual but it was actually seen in the wild -eval { - - my $dbh = $schema->storage->dbh; - undef $schema; - - $dbh->do ('glaring_syntax_error;'); -}; -like($@, qr/DBI Exception.+do failed/, 'Exception thrown even after $storage is destroyed'); - +done_testing; diff --git a/t/storage/error.t b/t/storage/error.t index d3b28aa..66b901a 100644 --- a/t/storage/error.t +++ b/t/storage/error.t @@ -32,6 +32,7 @@ throws_ok ( 'DBI exceptions properly handled by dbic-installed callback' ); +# This usage is a bit unusual but it was actually seen in the wild # destruction of everything except the $dbh should use the proper # exception fallback: