From: André Walker Date: Wed, 8 Jun 2011 14:45:20 +0000 (-0300) Subject: Fixed _config_substitutions to make tests work again X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6682389c3c6a9a856dea70722ff851d05250f8ad;p=catagits%2FCatalyst-Runtime.git Fixed _config_substitutions to make tests work again --- diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm index 2dd7d5d..6b43cc3 100644 --- a/lib/Catalyst.pm +++ b/lib/Catalyst.pm @@ -2466,7 +2466,7 @@ sub setup_config { $container->add_sub_container(Bread::Board::Container->new( name => $_ )) for qw(model controller view); $class->container($container); - my $config = $container->fetch('config')->get; + my $config = $container->resolve(service => 'config'); $class->config($config); $class->finalize_config; # back-compat } diff --git a/lib/Catalyst/Container.pm b/lib/Catalyst/Container.pm index b9ae62e..7e72c86 100644 --- a/lib/Catalyst/Container.pm +++ b/lib/Catalyst/Container.pm @@ -226,7 +226,7 @@ sub _fix_syntax { } sub _config_substitutions { - my ($self, $name, $subs) = @_; + my ( $self, $name, $subs, $arg ) = @_; $subs->{ HOME } ||= sub { shift->path_to( '' ); }; $subs->{ ENV } ||= @@ -244,11 +244,8 @@ sub _config_substitutions { $subs->{ literal } ||= sub { return $_[ 1 ]; }; my $subsre = join( '|', keys %$subs ); - for ( @_ ) { - my $arg = $_; - $arg =~ s{__($subsre)(?:\((.+?)\))?__}{ $subs->{ $1 }->( $name, $2 ? split( /,/, $2 ) : () ) }eg; - return $arg; - } + $arg =~ s{__($subsre)(?:\((.+?)\))?__}{ $subs->{ $1 }->( $name, $2 ? split( /,/, $2 ) : () ) }eg; + return $arg; } 1;