From: Craig A. Berry Date: Tue, 2 Mar 2010 00:56:45 +0000 (-0600) Subject: Cannot portably split on $Config{path_sep} -- use quotemeta($Config{path_sep}). X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=6061da081a4fed7b01d246a6004b4366c205b50e;p=p5sagit%2Fp5-mst-13.2.git Cannot portably split on $Config{path_sep} -- use quotemeta($Config{path_sep}). Broken in fc5e5837c991d3d3224259ff5c1d728d4e0636e2. On VMS we were getting: $ perl -"MConfig" -e "print join('+',split $Config{path_sep}, 'foo|bar|baz');" f+o+o+|+b+a+r+|+b+a+z which is a *lot* more pieces than we want. What was intended was: $ perl -"MConfig" -e "print join('+',split quotemeta($Config{path_sep}), 'foo|bar|baz');" foo+bar+baz No version bump as this is test infrastructure and 1.55 has not been released outside of development releases of blead. --- diff --git a/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm b/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm index c3c214c..453a8ed 100644 --- a/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm +++ b/dist/ExtUtils-Install/t/lib/MakeMaker/Test/Utils.pm @@ -149,7 +149,7 @@ sub perl_lib { # $ENV{PERL5LIB} will be set with this, but (by default) it's a relative # path. $ENV{PERL5LIB} = join $Config{path_sep}, map { - File::Spec->rel2abs($_) } split $Config{path_sep}, $ENV{PERL5LIB}; + File::Spec->rel2abs($_) } split quotemeta($Config{path_sep}), $ENV{PERL5LIB}; @INC = map { File::Spec->rel2abs($_) } @INC; } else { my $lib = 'blib/lib';