From: Dagfinn Ilmari Mannsåker Date: Wed, 3 Jun 2015 20:40:06 +0000 (+0100) Subject: Stop importing all the POSIX functions X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=5e5823f108f61bd7afa01c180102bc42bad3834b;p=dbsrgits%2FDBIx-Class-Historic.git Stop importing all the POSIX functions The only one used is called fully-qualified anyway --- diff --git a/t/87ordered.t b/t/87ordered.t index 324be84..1eb079b 100644 --- a/t/87ordered.t +++ b/t/87ordered.t @@ -6,7 +6,7 @@ use Test::More; use lib qw(t/lib); use DBICTest; -use POSIX qw(ceil); +use POSIX (); my $schema = DBICTest->init_schema(); @@ -156,7 +156,9 @@ $to_pos = undef; $to_pos++; $to_group = ($to_group % 3) + 1; $to_group_2_base++; - $to_group_2 = (ceil($to_group_2_base/3.0) %3) +1 + $to_group_2 = ( + POSIX::ceil( $to_group_2_base / 3.0 ) % 3 + ) + 1; } } foreach my $group_id_2 (1..4) { diff --git a/t/cdbi/testlib/Log.pm b/t/cdbi/testlib/Log.pm index 4f90ed1..362b61e 100644 --- a/t/cdbi/testlib/Log.pm +++ b/t/cdbi/testlib/Log.pm @@ -7,7 +7,7 @@ use strict; use base 'MyBase'; use Time::Piece::MySQL; -use POSIX; +use POSIX (); __PACKAGE__->set_table(); __PACKAGE__->columns(All => qw/id message datetime_stamp/); diff --git a/t/lib/DBICTest/Util/LeakTracer.pm b/t/lib/DBICTest/Util/LeakTracer.pm index 6f684e0..447d0ec 100644 --- a/t/lib/DBICTest/Util/LeakTracer.pm +++ b/t/lib/DBICTest/Util/LeakTracer.pm @@ -293,7 +293,7 @@ sub assert_empty_weakregistry { # Devel::MAT::Dumper::dumpfh( $fh ); # close ($fh) or die $!; # -# use POSIX; +# require POSIX; # POSIX::_exit(1); # } }