From: Peter Rabbitson <ribasushi@cpan.org>
Date: Fri, 26 Sep 2014 10:43:42 +0000 (+0200)
Subject: Bump CXSA dep, clarify thread-test boundaries
X-Git-Tag: v0.10011~3
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=5c87a5b19e42365de81b3ef9cf6af82a74206f0f;p=p5sagit%2FClass-Accessor-Grouped.git

Bump CXSA dep, clarify thread-test boundaries
---

diff --git a/Changes b/Changes
index 468f5d2..df9d0a4 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
 Revision history for Class::Accessor::Grouped.
 
+    - Soft-depend on newer (bugfixed and *simpler*) Class::XSAccessor 1.19
+
 0.10010 2013-04-24 02:58 (UTC)
     - Fix bug with identically-named 'simple' accessors in different
       classes set to access *differently named fields* getting their
diff --git a/Makefile.PL b/Makefile.PL
index d6b1a26..0d9a2c8 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -15,7 +15,7 @@ requires 'MRO::Compat' if $] < 5.009_005;
 my $recommends = {
   'Sub::Name' => '0.05',
   # when changing CXSA version don't forget to adjust lib/Class/Accessor/Grouped.pm as well
-  'Class::XSAccessor' => '1.15',
+  'Class::XSAccessor' => '1.19',
 };
 
 recommends( $_ => $recommends->{$_} )
diff --git a/lib/Class/Accessor/Grouped.pm b/lib/Class/Accessor/Grouped.pm
index f1fe9a9..52e2a25 100644
--- a/lib/Class/Accessor/Grouped.pm
+++ b/lib/Class/Accessor/Grouped.pm
@@ -20,7 +20,7 @@ $VERSION = eval $VERSION if $VERSION =~ /_/; # numify for warning-free dev relea
 
 # when changing minimum version don't forget to adjust Makefile.PL as well
 our $__minimum_xsa_version;
-BEGIN { $__minimum_xsa_version = '1.15' }
+BEGIN { $__minimum_xsa_version = '1.19' }
 
 our $USE_XS;
 # the unless defined is here so that we can override the value
diff --git a/t/accessors_xs.t b/t/accessors_xs.t
index e97a8a7..b373a94 100644
--- a/t/accessors_xs.t
+++ b/t/accessors_xs.t
@@ -1,6 +1,6 @@
 my $has_threads;
 BEGIN { eval '
-  use 5.008001;
+  use 5.008005; # older perls segfault on threading under CXSA
   use threads;
   use threads::shared;
   $has_threads = 1;
diff --git a/t/accessors_xs_cachedwarn.t b/t/accessors_xs_cachedwarn.t
index eecc8df..c6a5377 100644
--- a/t/accessors_xs_cachedwarn.t
+++ b/t/accessors_xs_cachedwarn.t
@@ -1,6 +1,6 @@
 my $has_threads;
 BEGIN { eval '
-  use 5.008004; # older perls get confused by $SIG fiddling
+  use 5.008005; # older perls get confused by $SIG fiddling under CXSA
   use threads;
   use threads::shared;
   $has_threads = 1;