From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Mon, 11 Apr 2005 09:11:53 +0000 (+0000)
Subject: Make the four-argument form of select() return undef
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=5c477709a8f3aa3110d51ae872950c20ff14fed6;p=p5sagit%2Fp5-mst-13.2.git

Make the four-argument form of select() return undef
instead of -1 on error.

p4raw-id: //depot/perl@24223
---

diff --git a/pod/perl593delta.pod b/pod/perl593delta.pod
index dfd80b1..54fbe54 100644
--- a/pod/perl593delta.pod
+++ b/pod/perl593delta.pod
@@ -10,6 +10,9 @@ L<perl592delta> for the differences between 5.8.0 and 5.9.2.
 
 =head1 Incompatible Changes
 
+The 4-argument form of select() now returns C<undef> on error (instead of
+-1).
+
 =head1 Core Enhancements
 
 =head1 Modules and Pragmata
diff --git a/pod/perlfunc.pod b/pod/perlfunc.pod
index 0fceb30..552587a 100644
--- a/pod/perlfunc.pod
+++ b/pod/perlfunc.pod
@@ -4603,8 +4603,7 @@ Note that whether C<select> gets restarted after signals (say, SIGALRM)
 is implementation-dependent.  See also L<perlport> for notes on the
 portability of C<select>.
 
-On error, C<select> behaves like the select(2) system call : it returns
--1 and sets C<$!>.
+On error, C<select> returns C<undef> and sets C<$!>.
 
 B<WARNING>: One should not attempt to mix buffered I/O (like C<read>
 or <FH>) with C<select>, except as permitted by POSIX, and even
diff --git a/pp_sys.c b/pp_sys.c
index 4b7944a..16f539b 100644
--- a/pp_sys.c
+++ b/pp_sys.c
@@ -1129,7 +1129,10 @@ PP(pp_sselect)
 	}
     }
 
-    PUSHi(nfound);
+    if (nfound == -1)
+	PUSHs(&PL_sv_undef);
+    else
+	PUSHi(nfound);
     if (GIMME == G_ARRAY && tbuf) {
 	value = (NV)(timebuf.tv_sec) +
 		(NV)(timebuf.tv_usec) / 1000000.0;