From: Nicholas Clark <nick@ccl4.org>
Date: Wed, 30 May 2001 23:20:58 +0000 (+0100)
Subject: Re: [PATCH doop.c] unused variable in Perl_do_join
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=5ba99574b995836e37952cfa1f94ae1305814178;p=p5sagit%2Fp5-mst-13.2.git

Re: [PATCH doop.c] unused variable in Perl_do_join
Message-ID: <20010530232058.B86445@plum.flirble.org>

p4raw-id: //depot/perl@10332
---

diff --git a/doop.c b/doop.c
index 14495b1..9dff1b7 100644
--- a/doop.c
+++ b/doop.c
@@ -648,7 +648,8 @@ Perl_do_join(pTHX_ register SV *sv, SV *del, register SV **mark, register SV **s
     STRLEN delimlen;
     STRLEN tmplen;
 
-    (void) SvPV(del, delimlen); /* get the delimlen */
+    (void) SvPV(del, delimlen); /* stringify and get the delimlen */
+    /* SvCUR assumes it's SvPOK() and woe betide you if it's not. */
 
     mark++;
     len = (items > 0 ? (delimlen * (items - 1) ) : 0);