From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Tue, 5 Aug 2014 14:44:53 +0000 (+0100)
Subject: Remove pointless disconnect after static ->load
X-Git-Tag: 0.07041~9
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=584aa86fc729513a68b03d36adeacbdb9a3f9b43;p=dbsrgits%2FDBIx-Class-Schema-Loader.git

Remove pointless disconnect after static ->load

It was added on the assumption that in static mode nothing else was
going to happen after the loading was done, but that's really none of
our concern, so we shouldn't interfere with it.

It also broke the in-transaction dump test with DBIC's new stricter
connectedness checking on txn ops (dbsrgits/dbix-class@d4702d53).
---

diff --git a/Changes b/Changes
index 8e14492..fe91dce 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,7 @@
 Revision history for Perl extension DBIx::Class::Schema::Loader
 
         - Fix many_to_many bridges going back to the same table
+        - Don't disconnect after ->load in static mode
 
 0.07040  2014-05-27
         - Add options to omit the version and timestamp from the
diff --git a/lib/DBIx/Class/Schema/Loader/DBI.pm b/lib/DBIx/Class/Schema/Loader/DBI.pm
index 700b3ab..5459096 100644
--- a/lib/DBIx/Class/Schema/Loader/DBI.pm
+++ b/lib/DBIx/Class/Schema/Loader/DBI.pm
@@ -270,8 +270,6 @@ sub load {
     local $self->dbh->{PrintError} = 0;
 
     $self->next::method(@_);
-
-    $self->schema->storage->disconnect unless $self->dynamic;
 }
 
 sub _sth_for {