From: Rafael Garcia-Suarez Date: Mon, 23 Jan 2006 15:28:51 +0000 (+0000) Subject: Now that change #26410 is reverted, mark as TODO the tests added X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=547ba77e482059c5dc0437d27dfca137d5a69911;p=p5sagit%2Fp5-mst-13.2.git Now that change #26410 is reverted, mark as TODO the tests added by change #26925. p4raw-link: @26925 on //depot/perl: 86f12da24a95dda38e6d599b881a5cca226226e4 p4raw-link: @26410 on //depot/perl: e26a497577f3ce7b9a4d9e1e62062839554dfd8f p4raw-id: //depot/perl@26928 --- diff --git a/t/op/pat.t b/t/op/pat.t index 004499f..96a056a 100755 --- a/t/op/pat.t +++ b/t/op/pat.t @@ -3432,7 +3432,7 @@ ok(("foba ba$s" =~ qr/(foo|BaSS|bar)/i) my $aeek = bless {}, 'wooosh'; eval {$aeek->gloople() =~ /(.)/g;}; - ok($@ eq "", "# TODO 26410 caused a regression") or print "# $@\n"; + ok($@ eq "", "//g match against return value of sub") or print "# $@\n"; } { @@ -3445,8 +3445,6 @@ ok(("foba ba$s" =~ qr/(foo|BaSS|bar)/i) } { - # Prior to change 26410 this did not work: - package lv; $var = "abc"; sub variable : lvalue { $var } @@ -3455,18 +3453,16 @@ ok(("foba ba$s" =~ qr/(foo|BaSS|bar)/i) my $o = bless [], "lv"; my $f = ""; eval { for (1..2) { $f .= $1 if $o->variable =~ /(.)/g } }; - ok($f eq "ab", "# pos retained between calls") or print "# $@\n"; + ok($f eq "ab", "pos retained between calls # TODO") or print "# $@\n"; } { - # Prior to change 26410 this did not work: - $var = "abc"; sub variable : lvalue { $var } my $f = ""; eval { for (1..2) { $f .= $1 if variable() =~ /(.)/g } }; - ok($f eq "ab", "# pos retained between calls") or print "# $@\n"; + ok($f eq "ab", "pos retained between calls # TODO") or print "# $@\n"; } # last test 1199