From: Gerrit P. Haase Date: Sat, 31 May 2003 14:12:07 +0000 (+0200) Subject: Two Cygwin patches from Gerrit. X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=538204d5c084ddeba9f54debc89d135829749520;p=p5sagit%2Fp5-mst-13.2.git Two Cygwin patches from Gerrit. Subject: [PATCH] perl.h, README.cygwin: Cygwin O_TEXT <> O_BINARY issue From: "Gerrit P. Haase" Date: Sat, 31 May 2003 14:12:07 +0200 Message-ID: <179860591535.20030531141207@familiehaase.de> Subject: [PATCH] t/io/layers.t, Cygwin != DOSISH Date: Sat, 31 May 2003 13:57:49 +0200 Message-ID: <11859733881.20030531135749@familiehaase.de> p4raw-id: //depot/perl@19654 --- diff --git a/README.cygwin b/README.cygwin index b1406c3..61b2601 100644 --- a/README.cygwin +++ b/README.cygwin @@ -31,7 +31,7 @@ about this project can be found at: A recent net or commercial release of Cygwin is required. -At the time this document was last updated, Cygwin 1.3.12 was current. +At the time this document was last updated, Cygwin 1.3.22 was current. =head2 Cygwin Configuration @@ -177,13 +177,13 @@ Undefining this symbol forces Perl to be compiled statically. =item * C<-Uusemymalloc> -By default Perl uses the malloc() included with the Perl source. If you -want to force Perl to build with the system malloc() undefine this symbol. +By default Perl uses the C included with the Perl source. If you +want to force Perl to build with the system C undefine this symbol. =item * C<-Uuseperlio> -Undefining this symbol disables the PerlIO abstraction, which is now the -default. +Undefining this symbol disables the PerlIO abstraction, PerlIO is now the +default, it is not recommended to disable PerlIO. =item * C<-Dusemultiplicity> @@ -218,7 +218,8 @@ for internal size and position calculations. =item * C<-Dmksymlinks> Use this to build perl outside of the source tree. This works with Cygwin. -Details can be found in the F document. +Details can be found in the F document. This is the recommended +way to build perl form sources. =back @@ -231,10 +232,10 @@ You may see some messages during Configure that seem suspicious. =item * I I is needed to build dynamic libraries, but it does not exist -when dlsym() checking occurs (it is not created until `C' runs). +when C checking occurs (it is not created until `C' runs). You will see the following message: - Checking whether your dlsym() needs a leading underscore ... + Checking whether your C needs a leading underscore ... ld2: not found I can't compile and run the test program. I'm guessing that dlsym doesn't need a leading underscore. @@ -367,9 +368,9 @@ NDBM_File and ODBM_File being built. With NTFS (and CYGWIN=ntsec), there should be no problems even if perl was built on FAT. -=head2 fork() failures in io_* tests +=head2 C failures in io_* tests -A fork() failure may result in the following tests failing: +A C failure may result in the following tests failing: ext/IO/lib/IO/t/io_multihomed.t ext/IO/lib/IO/t/io_sock.t @@ -405,20 +406,38 @@ to the translations applied to POSIX style pathnames). When a file is opened it is in either text or binary mode. In text mode a file is subject to CR/LF/Ctrl-Z translations. With Cygwin, the default -mode for an open() is determined by the mode of the mount that underlies -the file. Perl provides a binmode() function to set binary mode on files -that otherwise would be treated as text. sysopen() with the C +mode for an C is determined by the mode of the mount that underlies +the file. Perl provides a C function to set binary mode on files +that otherwise would be treated as text. C with the C flag sets text mode on files that otherwise would be treated as binary: sysopen(FOO, "bar", O_WRONLY|O_CREAT|O_TEXT) -lseek(), tell() and sysseek() only work with files opened in binary mode. +C, C and C only work with files opened in binary +mode. The text/binary issue is covered at length in the Cygwin documentation. +=item * PerlIO + +PerlIO overrides the default Cygwin Text/Binary behaviour. A file will +always treated as binary, regardless which mode of the mount it lives on, +just like it is in UNIX. So CR/LF translation needs to be requested in +either the C call like this: + + open(FH, ">:crlf", "out.txt"); + +which will do conversion from LF to CR/LF on the output, or in the +environment settings (add this to your .bashrc): + + export PERLIO=crlf + +which will pull in the crlf PerlIO layer which does LF -> CRLF conversion +on every output generated by perl. + =item * F<.exe> -The Cygwin stat(), lstat() and readlink() functions make the F<.exe> +The Cygwin C, C and C functions make the F<.exe> extension transparent by looking for F when you ask for F (unless a F also exists). Cygwin does not require a F<.exe> extension, but I adds it automatically when building a program. @@ -426,27 +445,27 @@ However, when accessing an executable as a normal file (e.g., I in a makefile) the F<.exe> is not transparent. The I included with Cygwin automatically appends a F<.exe> when necessary. -=item * chown() +=item * C -On WinNT chown() can change a file's user and group IDs. On Win9x chown() +On WinNT C can change a file's user and group IDs. On Win9x C is a no-op, although this is appropriate since there is no security model. =item * Miscellaneous -File locking using the C command to fcntl() is a stub that +File locking using the C command to C is a stub that returns C. -Win9x can not rename() an open file (although WinNT can). +Win9x can not C an open file (although WinNT can). -The Cygwin chroot() implementation has holes (it can not restrict file +The Cygwin C implementation has holes (it can not restrict file access by native Win32 programs). Inplace editing C of files doesn't work without doing a backup of the file being edited C because of windowish restrictions, -therefore Perl adds the C<.bak> automatically if you use C +therefore Perl adds the suffix C<.bak> automatically if you use C without specifying a backup extension. -Using fork() after loading multiple dlls may fail with an internal cygwin +Using C after loading multiple dlls may fail with an internal cygwin error like the following: C:\CYGWIN\BIN\PERL.EXE: *** couldn't allocate memory 0x10000(4128768) for 'C:\CYGWIN\LIB\PERL5\5.6.1\CYGWIN-MULTI\AUTO\SOCKET\SOCKET.DLL' alignment, Win32 error 8 @@ -456,7 +475,7 @@ error like the following: Use the rebase utility to resolve the conflicting dll addresses. The rebase package is included in the Cygwin netrelease. Use setup.exe from -F to install it. +F to install it and run rebaseall. =back @@ -556,7 +575,7 @@ be kept as clean as possible (listing not updated yet). =head1 BUGS ON CYGWIN Support for swapping real and effective user and group IDs is incomplete. -On WinNT Cygwin provides setuid(), seteuid(), setgid() and setegid(). +On WinNT Cygwin provides C, C, C and C. However, additional Cygwin calls for manipulating WinNT access tokens and security contexts are required. diff --git a/perl.h b/perl.h index c502d2b..f469d9e 100644 --- a/perl.h +++ b/perl.h @@ -4092,7 +4092,7 @@ int flock(int fd, int op); #if O_TEXT != O_BINARY /* If you have different O_TEXT and O_BINARY and you are a CLRF shop, * that is, you are somehow DOSish. */ -# if defined(__BEOS__) || defined(__VOS__) +# if defined(__BEOS__) || defined(__VOS__) || defined(__CYGWIN__) /* BeOS has O_TEXT != O_BINARY but O_TEXT and O_BINARY have no effect; * BeOS is always UNIXoid (LF), not DOSish (CRLF). */ /* VOS has O_TEXT != O_BINARY, and they have effect, diff --git a/t/io/layers.t b/t/io/layers.t index 193a517..31bb13b 100644 --- a/t/io/layers.t +++ b/t/io/layers.t @@ -29,7 +29,7 @@ plan tests => 43; use Config; -my $DOSISH = $^O =~ /^(?:MSWin32|cygwin|os2|dos|NetWare|mint)$/ ? 1 : 0; +my $DOSISH = $^O =~ /^(?:MSWin32|os2|dos|NetWare|mint)$/ ? 1 : 0; $DOSISH = 1 if !$DOSISH and $^O =~ /^uwin/; my $NONSTDIO = exists $ENV{PERLIO} && $ENV{PERLIO} ne 'stdio' ? 1 : 0; my $FASTSTDIO = $Config{d_faststdio} && $Config{usefaststdio} ? 1 : 0;