From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Tue, 31 Jul 2012 23:42:02 +0000 (+0100)
Subject: Mooify SQLT::Schema::View
X-Git-Tag: v0.11013_01~25
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=52068c9582384e80a9806471ce9af4c815262175;p=dbsrgits%2FSQL-Translator.git

Mooify SQLT::Schema::View
---

diff --git a/lib/SQL/Translator/Schema/View.pm b/lib/SQL/Translator/Schema/View.pm
index faae06c..51b76ec 100644
--- a/lib/SQL/Translator/Schema/View.pm
+++ b/lib/SQL/Translator/Schema/View.pm
@@ -23,34 +23,27 @@ C<SQL::Translator::Schema::View> is the view object.
 
 =cut
 
-use strict;
-use warnings;
-use SQL::Translator::Utils 'parse_list_arg';
+use Moo;
+use SQL::Translator::Utils qw(parse_list_arg ex2err);
+use SQL::Translator::Types qw(schema_obj);
+use List::MoreUtils qw(uniq);
 
-use base 'SQL::Translator::Schema::Object';
+with qw(
+  SQL::Translator::Schema::Role::Extra
+  SQL::Translator::Schema::Role::Error
+  SQL::Translator::Schema::Role::Compare
+);
 
 our ( $TABLE_COUNT, $VIEW_COUNT );
 
 our $VERSION = '1.59';
 
-__PACKAGE__->_attributes( qw/
-    name sql fields schema order tables options
-/);
-
-=pod
-
 =head2 new
 
 Object constructor.
 
   my $view = SQL::Translator::Schema::View->new;
 
-=cut
-
-sub fields {
-
-=pod
-
 =head2 fields
 
 Gets and set the fields the constraint is on.  Accepts a string, list or
@@ -67,27 +60,20 @@ names and keep them in order by the first occurrence of a field name.
 
 =cut
 
+has fields => (
+    is => 'rw',
+    default => sub { [] },
+    coerce => sub { [uniq @{parse_list_arg($_[0])}] },
+);
+
+around fields => sub {
+    my $orig   = shift;
     my $self   = shift;
     my $fields = parse_list_arg( @_ );
+    $self->$orig($fields) if @$fields;
 
-    if ( @$fields ) {
-        my ( %unique, @unique );
-        for my $f ( @$fields ) {
-            next if $unique{ $f }++;
-            push @unique, $f;
-        }
-
-        $self->{'fields'} = \@unique;
-    }
-
-    my @flds = @{ $self->{'fields'} || [] };
-
-    return wantarray ? @flds : \@flds;
-}
-
-sub tables {
-
-=pod
+    return wantarray ? @{ $self->$orig } : $self->$orig;
+};
 
 =head2 tables
 
@@ -105,27 +91,20 @@ names and keep them in order by the first occurrence of a field name.
 
 =cut
 
-    my $self   = shift;
-    my $tables = parse_list_arg( @_ );
-
-    if ( @$tables ) {
-        my ( %unique, @unique );
-        for my $t ( @$tables ) {
-            next if $unique{ $t }++;
-            push @unique, $t;
-        }
-
-        $self->{'tables'} = \@unique;
-    }
-
-    my @tbls = @{ $self->{'tables'} || [] };
-
-    return wantarray ? @tbls : \@tbls;
-}
+has tables => (
+    is => 'rw',
+    default => sub { [] },
+    coerce => sub { [uniq @{parse_list_arg($_[0])}] },
+);
 
-sub options {
+around tables => sub {
+    my $orig   = shift;
+    my $self   = shift;
+    my $fields = parse_list_arg( @_ );
+    $self->$orig($fields) if @$fields;
 
-=pod
+    return wantarray ? @{ $self->$orig } : $self->$orig;
+};
 
 =head2 options
 
@@ -137,23 +116,23 @@ Gets and sets a list of options on the view.
 
 =cut
 
+has options => (
+    is => 'rw',
+    default => sub { [] },
+    coerce => sub { [uniq @{parse_list_arg($_[0])}] },
+);
+
+around options => sub {
+    my $orig    = shift;
     my $self    = shift;
     my $options = parse_list_arg( @_ );
 
     if ( @$options ) {
-        my ( %unique, @unique );
-        for my $o ( @$options, @{ $self->{'options'} || [] } ) {
-            next if $unique{ $o }++;
-            push @unique, $o;
-        }
-
-        $self->{'options'} = \@unique;
+        $self->$orig([ @{$self->$orig}, @$options ])
     }
 
-    my @opts = @{ $self->{'options'} || [] };
-
-    return wantarray ? @opts : \@opts;
-}
+    return wantarray ? @{ $self->$orig } : $self->$orig;
+};
 
 sub is_valid {
 
@@ -175,10 +154,6 @@ Determine whether the view is valid or not.
     return 1;
 }
 
-sub name {
-
-=pod
-
 =head2 name
 
 Get or set the view's name.
@@ -187,14 +162,7 @@ Get or set the view's name.
 
 =cut
 
-    my $self        = shift;
-    $self->{'name'} = shift if @_;
-    return $self->{'name'} || '';
-}
-
-sub order {
-
-=pod
+has name => ( is => 'rw', default => sub { '' } );
 
 =head2 order
 
@@ -204,18 +172,17 @@ Get or set the view's order.
 
 =cut
 
-    my ( $self, $arg ) = @_;
+has order => ( is => 'rw', default => sub { 0 } );
+
+around order => sub {
+    my ( $orig, $self, $arg ) = @_;
 
     if ( defined $arg && $arg =~ /^\d+$/ ) {
-        $self->{'order'} = $arg;
+        return $self->$orig($arg);
     }
 
-    return $self->{'order'} || 0;
-}
-
-sub sql {
-
-=pod
+    return $self->$orig;
+};
 
 =head2 sql
 
@@ -225,14 +192,7 @@ Get or set the view's SQL.
 
 =cut
 
-    my $self       = shift;
-    $self->{'sql'} = shift if @_;
-    return $self->{'sql'} || '';
-}
-
-sub schema {
-
-=pod
+has sql => ( is => 'rw', default => sub { '' } );
 
 =head2 schema
 
@@ -243,19 +203,9 @@ Get or set the view's schema object.
 
 =cut
 
-    my $self = shift;
-    if ( my $arg = shift ) {
-        return $self->error('Not a schema object') unless
-            UNIVERSAL::isa( $arg, 'SQL::Translator::Schema' );
-        $self->{'schema'} = $arg;
-    }
+has schema => ( is => 'rw', isa => schema_obj('Schema') );
 
-    return $self->{'schema'};
-}
-
-sub equals {
-
-=pod
+around schema => \&ex2err;
 
 =head2 equals
 
@@ -265,12 +215,14 @@ Determines if this view is the same as another
 
 =cut
 
+around equals => sub {
+    my $orig = shift;
     my $self = shift;
     my $other = shift;
     my $case_insensitive = shift;
     my $ignore_sql = shift;
 
-    return 0 unless $self->SUPER::equals($other);
+    return 0 unless $self->$orig($other);
     return 0 unless $case_insensitive ? uc($self->name) eq uc($other->name) : $self->name eq $other->name;
     #return 0 unless $self->is_valid eq $other->is_valid;
 
@@ -291,13 +243,16 @@ Determines if this view is the same as another
     return 0 unless $case_insensitive ? uc($selfFields) eq uc($otherFields) : $selfFields eq $otherFields;
     return 0 unless $self->_compare_objects(scalar $self->extra, scalar $other->extra);
     return 1;
-}
+};
 
 sub DESTROY {
     my $self = shift;
     undef $self->{'schema'}; # destroy cyclical reference
 }
 
+# Must come after all 'has' declarations
+around new => \&ex2err;
+
 1;
 
 =pod