From: Jesse Luehrs Date: Tue, 10 Feb 2009 00:26:31 +0000 (+0000) Subject: add a note about not inlining delegation methods X-Git-Tag: 0.69~37 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=5120f8fff0b21f586b443f88aedc394a2e47be53;p=gitmo%2FMoose.git add a note about not inlining delegation methods --- diff --git a/lib/Moose/Meta/Method/Delegation.pm b/lib/Moose/Meta/Method/Delegation.pm index c924060..9891518 100644 --- a/lib/Moose/Meta/Method/Delegation.pm +++ b/lib/Moose/Meta/Method/Delegation.pm @@ -72,6 +72,10 @@ sub _initialize_body { # out. However, the more I thought about it, the less I liked it # doing the goto, and I prefered the act of delegation being # actually represented in the stack trace. - SL + # not inlining this, since it won't really speed things up at + # all... the only thing that would end up different would be + # interpolating in $method_to_call, and a bunch of things in the + # error handling that mostly never gets called - doy $self->{body} = sub { my $instance = shift; my $proxy = $instance->$accessor();