From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Thu, 12 May 2005 09:52:12 +0000 (+0000)
Subject: SvUPGRADE doesn't return false.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=5059e0eb8a88d633e26723e00d5f433320eda1e5;p=p5sagit%2Fp5-mst-13.2.git

SvUPGRADE doesn't return false.

p4raw-id: //depot/perl@24451
---

diff --git a/toke.c b/toke.c
index 72bedd9..a78866c 100644
--- a/toke.c
+++ b/toke.c
@@ -2146,8 +2146,7 @@ Perl_filter_add(pTHX_ filter_t funcp, SV *datasv)
 	PL_rsfp_filters = newAV();
     if (!datasv)
 	datasv = NEWSV(255,0);
-    if (!SvUPGRADE(datasv, SVt_PVIO))
-        Perl_die(aTHX_ "Can't upgrade filter_add data to SVt_PVIO");
+    (void)SvUPGRADE(datasv, SVt_PVIO);
     u.filter = funcp;
     IoANY(datasv) = u.iop; /* stash funcp into spare field */
     IoFLAGS(datasv) |= IOf_FAKE_DIRP;