From: Peter Rabbitson <ribasushi@cpan.org>
Date: Sat, 4 Jun 2016 09:23:17 +0000 (+0200)
Subject: Raise the global lock timeouts
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=501d6e066f4a0007c70749fccaac3777d645c623;p=dbsrgits%2FDBIx-Class-Historic.git

Raise the global lock timeouts

15 minutes on my laptop on battery with all assertions no longer cuts it :(
---

diff --git a/t/lib/DBICTest/Util.pm b/t/lib/DBICTest/Util.pm
index dc34406..3e250cc 100644
--- a/t/lib/DBICTest/Util.pm
+++ b/t/lib/DBICTest/Util.pm
@@ -76,7 +76,7 @@ sub dbg ($) {
 # This figure esentially means "how long can a single test hold a
 # resource before everyone else gives up waiting and aborts" or
 # in other words "how long does the longest test-group legitimally run?"
-my $lock_timeout_minutes = 15;  # yes, that's long, I know
+my $lock_timeout_minutes = 30;  # yes, that's long, I know
 my $wait_step_seconds = 0.25;
 
 sub await_flock ($$) {
@@ -109,6 +109,9 @@ sub await_flock ($$) {
     }
   }
 
+  print STDERR "Lock timeout of $lock_timeout_minutes minutes reached: "
+    unless $res;
+
   return $res;
 }
 
@@ -282,7 +285,7 @@ sub slurp_bytes ($) {
 
 
 sub rm_rf ($) {
-  croak "No valid argument supplied to rm_rf()" unless length "$_[0]";
+  croak "No argument supplied to rm_rf()" unless length "$_[0]";
 
   return unless -e $_[0];