From: Matt S Trout <mst@shadowcat.co.uk>
Date: Mon, 16 Apr 2018 02:17:23 +0000 (+0000)
Subject: notes about actions being disallowed
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4e1bf3a624d222f2f8ffd196c1f8db577e1f2ca9;p=scpubgit%2FDX.git

notes about actions being disallowed
---

diff --git a/lib/DX/Step/ResolveProposition.pm b/lib/DX/Step/ResolveProposition.pm
index 6cf99b9..7c7a454 100644
--- a/lib/DX/Step/ResolveProposition.pm
+++ b/lib/DX/Step/ResolveProposition.pm
@@ -56,6 +56,9 @@ sub apply_to {
   (my $hyp, my @recheck) = $old_hyp->with_resolution(
     $prop, $vdeps, $res->actions
   );
+  # Failure to have a $hyp here means an action was disallowed by policy
+  # or failed - unsure if "failed" should be permitted and unsure if policy
+  # checks belong in with_resolution
   unless ($hyp) {
     return $old_ss->but(
       next_step