From: Jarkko Hietaniemi <jhi@iki.fi>
Date: Tue, 19 Mar 2002 20:09:22 +0000 (+0000)
Subject: More pathname portability checks.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4d8cc5f8cae495ff0bcad4a9e629ad4bab92c057;p=p5sagit%2Fp5-mst-13.2.git

More pathname portability checks.

p4raw-id: //depot/perl@15337
---

diff --git a/Porting/check83.pl b/Porting/check83.pl
index 51b2b11..0522bc0 100644
--- a/Porting/check83.pl
+++ b/Porting/check83.pl
@@ -1,12 +1,22 @@
 #!/usr/local/bin/perl
 
-# Check whether there are naming conflicts when names are truncated
-# to the DOSish case-ignoring 8.3 format
+# Check whether there are naming conflicts when names are truncated to
+# the DOSish case-ignoring 8.3 format, plus other portability no-nos.
 
 sub eight_dot_three {
     my ($dir, $base, $ext) = ($_[0] =~ m!^(?:(.+)/)?([^/.]+)(?:\.([^/.]+))?$!);
+    my $file = $base . defined $ext ? ".$ext" : "";
     $base = substr($base, 0, 8);
     $ext  = substr($ext,  0, 3) if defined $ext;
+    if ($dir =~ /\./)  {
+	warn "$dir: directory name contains '.'\n";
+    }
+    if ($file =~ /[^A-Za-z0-9\._-]/) {
+	warn "$file: filename contains non-portable characters\n";
+    }
+    if (length $file > 30) {
+	warn "$file: filename longer than 30 characters\n";
+    }
     if (defined $dir) {
 	return ($dir, defined $ext ? "$dir/$base.$ext" : "$dir/$base");
     } else {