From: Dave Rolsky Date: Tue, 9 Feb 2010 23:26:19 +0000 (-0600) Subject: privatize apply_class_attributes and update pod coverage exclusions X-Git-Tag: 0.11~8 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4cbcd0f002a9fb56bbb71f41e652928d1d7ca8b8;p=gitmo%2FMooseX-ClassAttribute.git privatize apply_class_attributes and update pod coverage exclusions --- diff --git a/lib/MooseX/ClassAttribute/Trait/Application.pm b/lib/MooseX/ClassAttribute/Trait/Application.pm index 28159c1..72c071a 100644 --- a/lib/MooseX/ClassAttribute/Trait/Application.pm +++ b/lib/MooseX/ClassAttribute/Trait/Application.pm @@ -7,7 +7,7 @@ use namespace::autoclean; use Moose::Role; after apply_attributes => sub { - shift->apply_class_attributes(@_); + shift->_apply_class_attributes(@_); }; 1; diff --git a/lib/MooseX/ClassAttribute/Trait/Application/ToClass.pm b/lib/MooseX/ClassAttribute/Trait/Application/ToClass.pm index 08054ea..fb7892d 100644 --- a/lib/MooseX/ClassAttribute/Trait/Application/ToClass.pm +++ b/lib/MooseX/ClassAttribute/Trait/Application/ToClass.pm @@ -8,7 +8,7 @@ use Moose::Role; with 'MooseX::ClassAttribute::Trait::Application'; -sub apply_class_attributes { +sub _apply_class_attributes { my $self = shift; my $role = shift; my $class = shift; diff --git a/lib/MooseX/ClassAttribute/Trait/Application/ToInstance.pm b/lib/MooseX/ClassAttribute/Trait/Application/ToInstance.pm index 42f5df8..1fd5e57 100644 --- a/lib/MooseX/ClassAttribute/Trait/Application/ToInstance.pm +++ b/lib/MooseX/ClassAttribute/Trait/Application/ToInstance.pm @@ -9,10 +9,10 @@ use namespace::autoclean; use Moose::Role; after apply => sub { - shift->apply_class_attributes(@_); + shift->_apply_class_attributes(@_); }; -sub apply_class_attributes { +sub _apply_class_attributes { my $self = shift; my $role = shift; my $object = shift; diff --git a/lib/MooseX/ClassAttribute/Trait/Application/ToRole.pm b/lib/MooseX/ClassAttribute/Trait/Application/ToRole.pm index 2d2e23e..bf10e01 100644 --- a/lib/MooseX/ClassAttribute/Trait/Application/ToRole.pm +++ b/lib/MooseX/ClassAttribute/Trait/Application/ToRole.pm @@ -12,7 +12,7 @@ use Moose::Role; with 'MooseX::ClassAttribute::Trait::Application'; -sub apply_class_attributes { +sub _apply_class_attributes { my $self = shift; my $role1 = shift; my $role2 = shift; diff --git a/xt/pod-coverage.t b/xt/pod-coverage.t index 4522a21..7544bec 100644 --- a/xt/pod-coverage.t +++ b/xt/pod-coverage.t @@ -17,9 +17,13 @@ plan tests => scalar @modules; my %trustme = ( 'MooseX::ClassAttribute' => [ 'init_meta', 'class_has' ], + 'MooseX::ClassAttribute::Meta::Method::Accessor' => ['.+'], + 'MooseX::ClassAttribute::Meta::Role::Attribute' => ['new'], 'MooseX::ClassAttribute::Trait::Class' => ['compute_all_applicable_class_attributes'], - 'MooseX::ClassAttribute::Meta::Method::Accessor' => ['.+'] + 'MooseX::ClassAttribute::Trait::Mixin::HasClassAttributes' => [ + qw( add_class_attribute get_class_attribute_map remove_class_attribute ) + ], ); for my $module ( sort @modules ) {