From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: Sun, 21 Sep 2014 22:41:15 +0000 (+0100)
Subject: Narrow the scope of Oracle roundtrip TODO
X-Git-Tag: v0.11021~15^2
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4c9c21e68ca1b9229ed021b3f3816a9a63a8a866;p=dbsrgits%2FSQL-Translator.git

Narrow the scope of Oracle roundtrip TODO

The parser can now understand the producer output, but doesn't turn the
triggers it generates back into is_auto_increment and timestamp fields.
---

diff --git a/t/60roundtrip.t b/t/60roundtrip.t
index 9079406..f0e000d 100644
--- a/t/60roundtrip.t
+++ b/t/60roundtrip.t
@@ -62,7 +62,7 @@ my $plan = [
     engine => 'Oracle',
     producer_args => {},
     parser_args => {},
-    todo => 'Needs volunteers',
+    todo_cmp => "auto-increment triggers aren't detected",
   },
   {
     engine => 'Sybase',
@@ -140,7 +140,7 @@ for my $args (@$plan) {
       local $::RD_HINT = 0 if $args->{todo};
 
       lives_ok (
-        sub { check_roundtrip ($args, $base_schema) },
+        sub { check_roundtrip ($args, $base_schema, $args->{todo_cmp}) },
         "Round trip for $args->{name} did not throw an exception",
       );
     }
@@ -149,7 +149,7 @@ for my $args (@$plan) {
 
 
 sub check_roundtrip {
-  my ($args, $base_schema) = @_;
+  my ($args, $base_schema, $todo_cmp) = @_;
   my $base_t = $base_schema->translator;
 
 # create some output from the submitted schema
@@ -224,6 +224,7 @@ sub check_roundtrip {
     return;
   };
 
+  local $TODO = $todo_cmp;
 # the two sql strings should be identical
   my $msg = "$args->{name} SQL roundtrip successful - SQL statements match";
   $ENV{SQLTTEST_RT_DEBUG}