From: Steve Peters Date: Tue, 3 Oct 2006 13:19:48 +0000 (+0000) Subject: Upgrade to ExtUtils-Manifest-1.48 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4c857482444fa7fd66ed25e3d116ce432288ecb3;p=p5sagit%2Fp5-mst-13.2.git Upgrade to ExtUtils-Manifest-1.48 p4raw-id: //depot/perl@28921 --- diff --git a/lib/ExtUtils/Manifest.pm b/lib/ExtUtils/Manifest.pm index e5ef01a..ea1c067 100644 --- a/lib/ExtUtils/Manifest.pm +++ b/lib/ExtUtils/Manifest.pm @@ -13,7 +13,7 @@ use vars qw($VERSION @ISA @EXPORT_OK $Is_MacOS $Is_VMS $Debug $Verbose $Quiet $MANIFEST $DEFAULT_MSKIP); -$VERSION = '1.46_01'; +$VERSION = '1.48'; @ISA=('Exporter'); @EXPORT_OK = qw(mkmanifest manicheck filecheck fullcheck skipcheck @@ -701,7 +701,9 @@ L which has handy targets for most of the functionality. Andreas Koenig C -Currently maintained by Michael G Schwern C +Maintained by Michael G Schwern C within the +ExtUtils-MakeMaker package and, as a separate CPAN package, by +Randy Kobes C. =cut diff --git a/lib/ExtUtils/t/Manifest.t b/lib/ExtUtils/t/Manifest.t index b90c233..396789e 100644 --- a/lib/ExtUtils/t/Manifest.t +++ b/lib/ExtUtils/t/Manifest.t @@ -46,7 +46,7 @@ sub read_manifest { } sub catch_warning { - my $warn = ''; + my $warn; local $SIG{__WARN__} = sub { $warn .= $_[0] }; return join('', $_[0]->() ), $warn; } @@ -72,7 +72,7 @@ ok( chdir( 'mantest' ), 'chdir() to mantest' ); ok( add_file('foo'), 'add a temporary file' ); # there shouldn't be a MANIFEST there -my ($res, $warn) = catch_warning( \&mkmanifest ); +my ($res, $warn) = catch_warning( \&mkmanifest ); # Canonize the order. $warn = join("", map { "$_|" } sort { lc($a) cmp lc($b) } split /\r?\n/, $warn); @@ -97,10 +97,10 @@ like( $warn, qr/^Not in MANIFEST: bar/, 'warning that bar has been added' ); is( $res, 'bar', 'bar reported as new' ); # now quiet the warning that bar was added and test again -($res, $warn) = do { local $ExtUtils::Manifest::Quiet = 1; - catch_warning( \&skipcheck ) +($res, $warn) = do { local $ExtUtils::Manifest::Quiet = 1; + catch_warning( \&skipcheck ) }; -is( $warn, '', 'disabled warnings' ); +cmp_ok( $warn, 'eq', '', 'disabled warnings' ); # add a skip file with a rule to skip itself (and the nonexistent glob '*baz*') add_file( 'MANIFEST.SKIP', "baz\n.SKIP" ); @@ -111,7 +111,7 @@ like( $warn, qr/^Skipping MANIFEST\.SKIP/i, 'got skipping warning' ); my @skipped; catch_warning( sub { - @skipped = skipcheck(); + @skipped = skipcheck() }); is( join( ' ', @skipped ), 'MANIFEST.SKIP', 'listed skipped files' ); @@ -150,8 +150,8 @@ is_deeply( [sort map { lc } @copies], [sort map { lc } keys %$files] ); foreach my $orig (@copies) { my $copy = "copy/$orig"; ok( -r $copy, "$copy: must be readable" ); - is( -w $copy, -w $orig, " has orig write state" ); - is( -x $copy, -x $orig, " has orig executable state" ); + is( -w $copy, -w $orig, " writable if original was" ); + is( -x $copy, -x $orig, " executable if original was" ); } rmtree('copy'); @@ -199,8 +199,8 @@ add_file( 'MANIFEST.SKIP' => 'foo' ); add_file( 'MANIFEST' => "foobar\n" ); add_file( 'foobar' => '123' ); ($res, $warn) = catch_warning( \&manicheck ); -is( $res, '', 'MANIFEST overrides MANIFEST.SKIP' ); -is( $warn, '', 'MANIFEST overrides MANIFEST.SKIP, no warnings' ); +is( $res, '', 'MANIFEST overrides MANIFEST.SKIP' ); +is( $warn, undef, 'MANIFEST overrides MANIFEST.SKIP, no warnings' ); $files = maniread; ok( !$files->{wibble}, 'MANIFEST in good state' );