From: Peter Rabbitson Date: Sun, 8 Feb 2015 10:11:00 +0000 (+0100) Subject: Fix overspecified msaccess test optdep (should not include icdt) X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4b9c54b5ec80c996721e1187b5f2cf1014863b58;p=dbsrgits%2FDBIx-Class.git Fix overspecified msaccess test optdep (should not include icdt) The test_rdbms_msaccess_* groups are only referenced in two tests. The basic one does not exercise (doesn't even load) any of the ICDT handling components The ICDT test already explicitly requires test_dt, so no changes are needed within the actual tests The erroneous requirement was introduced in 726c8f65 and never revised since --- diff --git a/lib/DBIx/Class/Optional/Dependencies.pm b/lib/DBIx/Class/Optional/Dependencies.pm index cca513c..8ba4779 100644 --- a/lib/DBIx/Class/Optional/Dependencies.pm +++ b/lib/DBIx/Class/Optional/Dependencies.pm @@ -424,7 +424,7 @@ my $dbic_reqs = { }, test_rdbms_msaccess_odbc => { - include => [qw(rdbms_msaccess_odbc test_dt)], + include => 'rdbms_msaccess_odbc', env => [ DBICTEST_MSACCESS_ODBC_DSN => 1, DBICTEST_MSACCESS_ODBC_USER => 0, @@ -436,7 +436,7 @@ my $dbic_reqs = { }, test_rdbms_msaccess_ado => { - include => [qw(rdbms_msaccess_ado test_dt)], + include => 'rdbms_msaccess_ado', env => [ DBICTEST_MSACCESS_ADO_DSN => 1, DBICTEST_MSACCESS_ADO_USER => 0,