From: Matt S Trout Date: Fri, 11 May 2007 12:38:18 +0000 (+0000) Subject: fixup for Oracle WHERE join stuff from abraxxa X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=4a90cd566ba712f4b56e2e8259d84a949f4b342a;p=dbsrgits%2FDBIx-Class-Historic.git fixup for Oracle WHERE join stuff from abraxxa --- diff --git a/lib/DBIx/Class/Storage/DBI/Oracle/WhereJoins.pm b/lib/DBIx/Class/Storage/DBI/Oracle/WhereJoins.pm index 2ba6815..9dbe9e0 100644 --- a/lib/DBIx/Class/Storage/DBI/Oracle/WhereJoins.pm +++ b/lib/DBIx/Class/Storage/DBI/Oracle/WhereJoins.pm @@ -58,10 +58,10 @@ BEGIN { die "Can't handle full outer joins in Oracle 8 yet!\n" if $to_jt->{-join_type} =~ /full/i; - $left_join = q{(+)} if $to_jt->{-join_type} =~ /right/i + $left_join = q{(+)} if $to_jt->{-join_type} =~ /left/i && $to_jt->{-join_type} !~ /inner/i; - $right_join = q{(+)} if $to_jt->{-join_type} =~ /left/i + $right_join = q{(+)} if $to_jt->{-join_type} =~ /right/i && $to_jt->{-join_type} !~ /inner/i; }