From: Yuval Kogman <nothingmuch@woobling.org>
Date: Mon, 2 Jun 2008 15:17:07 +0000 (+0000)
Subject: load_plugins withs all the plugins in one go
X-Git-Tag: 0.0008~6
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=485dad3c41d5170043c33c09cdea1e5f64bd2fef;p=gitmo%2FMooseX-Object-Pluggable.git

load_plugins withs all the plugins in one go
---

diff --git a/lib/MooseX/Object/Pluggable.pm b/lib/MooseX/Object/Pluggable.pm
index 437601b..ceaacb2 100644
--- a/lib/MooseX/Object/Pluggable.pm
+++ b/lib/MooseX/Object/Pluggable.pm
@@ -144,6 +144,8 @@ has _plugin_locator => (is => 'rw', required => 1, lazy => 1,
 
 =head1 Public Methods
 
+=head2 load_plugins @plugins
+
 =head2 load_plugin $plugin
 
 Load the apropriate role for C<$plugin> as well as any extensions it provides
@@ -151,31 +153,33 @@ if extensions are enabled.
 
 =cut
 
-sub load_plugin{
-    my ($self, $plugin) = @_;
-    die("You must provide a plugin name") unless $plugin;
+sub load_plugins {
+    my ($self, @plugins) = @_;
+    die("You must provide a plugin name") unless @plugins;
 
     my $loaded = $self->_plugin_loaded;
-    return 1 if exists $loaded->{$plugin};
-
-    my $role = $self->_role_from_plugin($plugin);
 
-    $loaded->{$plugin} = $role      if $self->_load_and_apply_role($role);
-    $self->load_plugin_ext($plugin) if $self->_plugin_ext;
+    my @load = grep { not exists $loaded->{$_} } @plugins;
 
-    return exists $loaded->{$plugin};
-}
+    my @roles = map { $self->_role_from_plugin($_) } @load;
 
-=head2 load_plugins @plugins
+    if ( $self->_load_and_apply_role(@roles) ) {
+        @{ $loaded }{@load} = @roles;
 
-Load all C<@plugins>.
+        if ( $self->_plugin_ext ) {
+            $self->load_plugin_ext($_) for @load;
+        }
 
-=cut
+        return 1;
+    } else {
+        return;
+    }
+}
 
 
-sub load_plugins {
+sub load_plugin {
   my $self = shift;
-  $self->load_plugin($_) for @_;
+  $self->load_plugins(@_);
 }
 
 
@@ -270,7 +274,7 @@ sub _role_from_plugin{
     return shift @roles;
 }
 
-=head2 _load_and_apply_role $role
+=head2 _load_and_apply_role @roles
 
 Require C<$role> if it is not already loaded and apply it. This is
 the meat of this module.
@@ -278,17 +282,20 @@ the meat of this module.
 =cut
 
 sub _load_and_apply_role{
-    my ($self, $role) = @_;
-    die("You must provide a role name") unless $role;
+    my ($self, @roles) = @_;
+    die("You must provide a role name") unless @roles;
 
-    eval { Class::MOP::load_class($role) };
-    confess("Failed to load role: ${role} $@") if $@;
+    foreach my $role ( @roles ) {
+        eval { Class::MOP::load_class($role) };
+        confess("Failed to load role: ${role} $@") if $@;
 
-    carp("Using 'override' is strongly discouraged and may not behave ".
-         "as you expect it to. Please use 'around'")
+        carp("Using 'override' is strongly discouraged and may not behave ".
+            "as you expect it to. Please use 'around'")
         if scalar keys %{ $role->meta->get_override_method_modifiers_map };
+    }
+
+    Moose::Util::apply_all_roles( $self, @roles );
 
-    $role->meta->apply( $self );
     return 1;
 }