From: Matt S Trout <mst@shadowcat.co.uk>
Date: Sat, 12 Oct 2013 19:45:55 +0000 (+0000)
Subject: improve order by error message
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=458332d9a950b958808fb68df0be638e6f9c45ab;p=dbsrgits%2FDBIx-Class.git

improve order by error message
---

diff --git a/lib/DBIx/Class/SQLMaker.pm b/lib/DBIx/Class/SQLMaker.pm
index dc62763..dac76df 100644
--- a/lib/DBIx/Class/SQLMaker.pm
+++ b/lib/DBIx/Class/SQLMaker.pm
@@ -180,7 +180,7 @@ sub select {
         if ($stability eq 'requires') {
           if ($self->converter->_order_by_to_dq($final_attrs{order_by})) {
             $self->throw_exception(
-                $self->limit_dialect.' limit/offset implementation requires a stable order for offset'
+                $self->limit_dialect.' limit/offset implementation requires a stable order for '.($offset ? 'offset' : 'limit').' but you gave me '.$self->_render_sqla(order_by => $final_attrs{order_by})
             );
           }
           if (my $ident_cols = $source->_identifying_column_set) {