From: Peter Rabbitson Date: Thu, 12 Mar 2015 14:10:15 +0000 (+0100) Subject: Do not attempt to load DBD::Oracle without envvars X-Git-Tag: v0.082820~9 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=44c91cabaf0f54d7e95285e09c6e98fa75a796a1;p=dbsrgits%2FDBIx-Class.git Do not attempt to load DBD::Oracle without envvars This is morally equivalent to 250d9e55, except without any of the new OptDep shinies --- diff --git a/t/inflate/datetime_oracle.t b/t/inflate/datetime_oracle.t index 9182f23..25a9366 100644 --- a/t/inflate/datetime_oracle.t +++ b/t/inflate/datetime_oracle.t @@ -7,9 +7,6 @@ use DBIx::Class::Optional::Dependencies (); use lib qw(t/lib); use DBICTest; -plan skip_all => 'Test needs ' . DBIx::Class::Optional::Dependencies->req_missing_for ('test_rdbms_oracle') - unless DBIx::Class::Optional::Dependencies->req_ok_for ('test_rdbms_oracle'); - my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_ORA_${_}" } qw/DSN USER PASS/}; if (not ($dsn && $user && $pass)) { @@ -17,6 +14,10 @@ if (not ($dsn && $user && $pass)) { 'Warning: This test drops and creates a table called \'event\''; } +plan skip_all => 'Test needs ' . DBIx::Class::Optional::Dependencies->req_missing_for ('test_rdbms_oracle') + unless DBIx::Class::Optional::Dependencies->req_ok_for ('test_rdbms_oracle'); + + # DateTime::Format::Oracle needs this set $ENV{NLS_DATE_FORMAT} = 'DD-MON-YY'; $ENV{NLS_TIMESTAMP_FORMAT} = 'YYYY-MM-DD HH24:MI:SSXFF';