From: Dave Rolsky <autarch@urth.org>
Date: Fri, 15 Apr 2011 15:23:29 +0000 (-0500)
Subject: Drop optimized subs for all builtins - instead use the inlining code to generate... 
X-Git-Tag: 2.0100~72
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=43837b8ab8edee54f027e72040b7a766e0b7d430;p=gitmo%2FMoose.git

Drop optimized subs for all builtins - instead use the inlining code to generate a sub

Fix inline code for ArrayRef & HashRef type - need to check the ref type of
the value before dereferencing it

Fix TODO test to test the right thing in inlining.t
---

diff --git a/lib/Moose/Meta/TypeConstraint.pm b/lib/Moose/Meta/TypeConstraint.pm
index 1f657ca..59fa7ec 100644
--- a/lib/Moose/Meta/TypeConstraint.pm
+++ b/lib/Moose/Meta/TypeConstraint.pm
@@ -234,6 +234,14 @@ sub _actually_compile_type_constraint {
     return $self->_compile_hand_optimized_type_constraint
         if $self->has_hand_optimized_type_constraint;
 
+    if ( $self->has_inlined_type_constraint ) {
+        local $@;
+        my $sub = eval 'sub { ' . $self->_inline_check('$_[0]') . '}';
+        die $@ if $@;
+
+        return $sub;
+    }
+
     my $check = $self->constraint;
     unless ( defined $check ) {
         require Moose;
diff --git a/lib/Moose/Util/TypeConstraints/Builtins.pm b/lib/Moose/Util/TypeConstraints/Builtins.pm
index 35c1390..e232e5d 100644
--- a/lib/Moose/Util/TypeConstraints/Builtins.pm
+++ b/lib/Moose/Util/TypeConstraints/Builtins.pm
@@ -42,19 +42,16 @@ sub define_builtins {
     subtype 'Value'
         => as 'Defined'
         => where { !ref($_) }
-        => optimize_as( \&_Value )
         => inline_as { "defined $_[1] && ! ref $_[1]" };
 
     subtype 'Ref'
         => as 'Defined'
         => where { ref($_) }
-        => optimize_as( \&_Ref )
         => inline_as { "ref $_[1]" };
 
     subtype 'Str'
         => as 'Value'
         => where { ref(\$_) eq 'SCALAR' }
-        => optimize_as( \&_Str )
         => inline_as {
             return (  qq{defined $_[1]}
                     . qq{&& (   ref(\\             $_[1] ) eq 'SCALAR'}
@@ -64,13 +61,11 @@ sub define_builtins {
     subtype 'Num'
         => as 'Str'
         => where { Scalar::Util::looks_like_number($_) }
-        => optimize_as( \&_Num )
         => inline_as { "!ref $_[1] && Scalar::Util::looks_like_number($_[1])" };
 
     subtype 'Int'
         => as 'Num'
         => where { "$_" =~ /^-?[0-9]+$/ }
-        => optimize_as( \&_Int )
         => inline_as {
             return (  qq{defined $_[1]}
                     . qq{&& ! ref $_[1]}
@@ -80,19 +75,16 @@ sub define_builtins {
     subtype 'CodeRef'
         => as 'Ref'
         => where { ref($_) eq 'CODE' }
-        => optimize_as( \&_CodeRef )
         => inline_as { qq{ref $_[1] eq 'CODE'} };
 
     subtype 'RegexpRef'
         => as 'Ref'
         => where( \&_RegexpRef )
-        => optimize_as( \&_RegexpRef )
         => inline_as { "Moose::Util::TypeConstraints::Builtins::_RegexpRef( $_[1] )" };
 
     subtype 'GlobRef'
         => as 'Ref'
         => where { ref($_) eq 'GLOB' }
-        => optimize_as( \&_GlobRef )
         => inline_as { qq{ref $_[1] eq 'GLOB'} };
 
     # NOTE: scalar filehandles are GLOB refs, but a GLOB ref is not always a
@@ -102,7 +94,6 @@ sub define_builtins {
         => where {
             Scalar::Util::openhandle($_) || ( blessed($_) && $_->isa("IO::Handle") );
         }
-        => optimize_as( \&_FileHandle )
         => inline_as {
             return (  qq{ref $_[1] eq 'GLOB'}
                     . qq{&& Scalar::Util::openhandle( $_[1] )}
@@ -112,19 +103,16 @@ sub define_builtins {
     subtype 'Object'
         => as 'Ref'
         => where { blessed($_) }
-        => optimize_as( \&_Object )
         => inline_as { "Scalar::Util::blessed( $_[1] )" };
 
     # This type is deprecated.
     subtype 'Role'
         => as 'Object'
-        => where { $_->can('does') }
-        => optimize_as( \&_Role );
+        => where { $_->can('does') };
 
     subtype 'ClassName'
         => as 'Str'
         => where { Class::MOP::is_class_loaded($_) }
-        => optimize_as( \&_ClassName )
         => inline_as { "Class::MOP::is_class_loaded( $_[1] )" };
 
     subtype 'RoleName'
@@ -132,7 +120,6 @@ sub define_builtins {
         => where {
             (Class::MOP::class_of($_) || return)->isa('Moose::Meta::Role');
         }
-        => optimize_as( \&_RoleName )
         => inline_as {
             return (  qq{Class::MOP::is_class_loaded( $_[1] )}
                     . qq{&& ( Class::MOP::class_of( $_[1] ) || return )}
@@ -146,7 +133,6 @@ sub define_builtins {
             parent =>
                 Moose::Util::TypeConstraints::find_type_constraint('Ref'),
             constraint => sub { ref($_) eq 'SCALAR' || ref($_) eq 'REF' },
-            optimized            => \&_ScalarRef,
             constraint_generator => sub {
                 my $type_parameter = shift;
                 my $check = $type_parameter->_compiled_type_constraint;
@@ -159,8 +145,8 @@ sub define_builtins {
                 my $self           = shift;
                 my $type_parameter = shift;
                 my $val            = shift;
-                return $type_parameter->_inline_check(
-                    '${ (' . $val . ') }' );
+                return qq{(ref $val eq 'SCALAR' || ref $val eq 'REF') && }
+                    . $type_parameter->_inline_check( '${ (' . $val . ') }' );
             },
         )
     );
@@ -172,7 +158,6 @@ sub define_builtins {
             parent =>
                 Moose::Util::TypeConstraints::find_type_constraint('Ref'),
             constraint => sub { ref($_) eq 'ARRAY' },
-            optimized => \&_ArrayRef,
             constraint_generator => sub {
                 my $type_parameter = shift;
                 my $check = $type_parameter->_compiled_type_constraint;
@@ -189,7 +174,8 @@ sub define_builtins {
                 my $type_parameter = shift;
                 my $val            = shift;
                 return
-                      '&List::MoreUtils::all( sub { '
+                      qq{ref $val eq 'ARRAY' && }
+                    . '&List::MoreUtils::all( sub { '
                     . $type_parameter->_inline_check('$_')
                     . " }, \@{$val} )";
             },
@@ -203,7 +189,6 @@ sub define_builtins {
             parent =>
                 Moose::Util::TypeConstraints::find_type_constraint('Ref'),
             constraint => sub { ref($_) eq 'HASH' },
-            optimized => \&_HashRef,
             constraint_generator => sub {
                 my $type_parameter = shift;
                 my $check = $type_parameter->_compiled_type_constraint;
@@ -220,7 +205,8 @@ sub define_builtins {
                 my $type_parameter = shift;
                 my $val            = shift;
                 return
-                      '&List::MoreUtils::all( sub { '
+                      qq{ref $val eq 'HASH' && }
+                    . '&List::MoreUtils::all( sub { '
                     . $type_parameter->_inline_check('$_')
                     . " }, values \%{$val} )";
             },
@@ -255,59 +241,4 @@ sub define_builtins {
     );
 }
 
-sub _Value { defined($_[0]) && !ref($_[0]) }
-
-sub _Ref { ref($_[0]) }
-
-# We might need to use a temporary here to flatten LVALUEs, for instance as in
-# Str(substr($_,0,255)).
-sub _Str {
-    defined($_[0])
-      && (   ref(\             $_[0] ) eq 'SCALAR'
-          || ref(\(my $value = $_[0])) eq 'SCALAR')
-}
-
-sub _Num { !ref($_[0]) && looks_like_number($_[0]) }
-
-# using a temporary here because regex matching promotes an IV to a PV,
-# and that confuses some things (like JSON.pm)
-sub _Int {
-    my $value = $_[0];
-    defined($value) && !ref($value) && $value =~ /\A-?[0-9]+\z/
-}
-
-sub _ScalarRef { ref($_[0]) eq 'SCALAR' || ref($_[0]) eq 'REF' }
-sub _ArrayRef  { ref($_[0]) eq 'ARRAY'  }
-sub _HashRef   { ref($_[0]) eq 'HASH'   }
-sub _CodeRef   { ref($_[0]) eq 'CODE'   }
-sub _GlobRef   { ref($_[0]) eq 'GLOB'   }
-
-# RegexpRef is implemented in Moose.xs
-
-sub _FileHandle {
-    ref( $_[0] ) eq 'GLOB' && Scalar::Util::openhandle( $_[0] )
-        or blessed( $_[0] ) && $_[0]->isa("IO::Handle");
-}
-
-sub _Object { blessed($_[0]) }
-
-sub _Role {
-    Moose::Deprecated::deprecated(
-        feature => 'Role type',
-        message =>
-            'The Role type has been deprecated. Maybe you meant to create a RoleName type? This type be will be removed in Moose 2.0200.'
-    );
-    blessed( $_[0] ) && $_[0]->can('does');
-}
-
-sub _ClassName {
-    return Class::MOP::is_class_loaded( $_[0] );
-}
-
-sub _RoleName {
-    _ClassName( $_[0] )
-        && ( Class::MOP::class_of( $_[0] ) || return )
-        ->isa('Moose::Meta::Role');
-}
-
 1;
diff --git a/t/type_constraints/inlining.t b/t/type_constraints/inlining.t
index 1523366..5e6ebac 100644
--- a/t/type_constraints/inlining.t
+++ b/t/type_constraints/inlining.t
@@ -57,7 +57,7 @@ my $not_inlinable = find_type_constraint('NotInlinable');
 
     is(
         $aofi->_inline_check('$foo'),
-        '&List::MoreUtils::all( sub { defined $_ && ! ref $_ && $_ !~ /Q/ }, @{$foo} )',
+        q{ref $foo eq 'ARRAY' && &List::MoreUtils::all( sub { defined $_ && ! ref $_ && $_ !~ /Q/ }, @{$foo} )},
         'got expected inline code for ArrayRef[Inlinable] constraint'
     );
 
@@ -80,7 +80,7 @@ subtype 'ArrayOfNotInlinable',
     local $TODO = 'A subtype of a Parameterized type should not be a Parameterizable type';
 
     my $aofi = Moose::Util::TypeConstraints::find_or_create_type_constraint(
-        'ArrayRef[Inlinable]');
+        'ArrayOfInlinable');
 
     ok(
         $aofi->has_inlined_type_constraint,
@@ -99,7 +99,7 @@ subtype 'ArrayOfNotInlinable',
 
     is(
         $hoaofi->_inline_check('$foo'),
-        '&List::MoreUtils::all( sub { &List::MoreUtils::all( sub { defined $_ && ! ref $_ && $_ !~ /Q/ }, @{$_} ) }, values %{$foo} )',
+        q{ref $foo eq 'HASH' && &List::MoreUtils::all( sub { ref $_ eq 'ARRAY' && &List::MoreUtils::all( sub { defined $_ && ! ref $_ && $_ !~ /Q/ }, @{$_} ) }, values %{$foo} )},
         'got expected inline code for HashRef[ArrayRef[Inlinable]] constraint'
     );
 
@@ -184,6 +184,4 @@ subtype 'ArrayOfNotInlinable',
     );
 }
 
-
-
 done_testing;