From: Alexander Hartmaier Date: Tue, 12 Jan 2010 17:04:18 +0000 (+0000) Subject: fixed a typo in Changes X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=416e0bc0624a788f9e6389790b5beb20ced77a43;p=dbsrgits%2FDBIx-Class-Historic.git fixed a typo in Changes more detailed explanation for the warning about has_one/might_have rels on nullable columns --- diff --git a/Changes b/Changes index 9bc4326..359cb56 100644 --- a/Changes +++ b/Changes @@ -16,7 +16,7 @@ Revision history for DBIx::Class - Better isolation of RNO-limited queries from the rest of a prefetching resultset - New MSSQL specific resultset attribute to allow hacky ordered - subquery suppot + subquery support - Fix nasty schema/dbhandle leak due to SQL::Translator 0.08115 2009-12-10 09:02:00 (CST) diff --git a/lib/DBIx/Class/Relationship/HasOne.pm b/lib/DBIx/Class/Relationship/HasOne.pm index 73cb929..1578c63 100644 --- a/lib/DBIx/Class/Relationship/HasOne.pm +++ b/lib/DBIx/Class/Relationship/HasOne.pm @@ -82,7 +82,7 @@ sub _validate_cond { my $key = $1; my $column_info = $class->column_info($key); if ( $column_info->{is_nullable} ) { - carp(qq'"might_have/has_one" must not be on columns with is_nullable set to true ($class/$key) '); + carp(qq'"might_have/has_one" must not be on columns with is_nullable set to true ($class/$key). This might indicate an incorrect use of those relationship helpers instead of belongs_to.'); } } }