From: Peter Rabbitson Date: Sat, 1 Nov 2008 14:23:15 +0000 (+0000) Subject: TODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite... X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=40708af1d856abcb5044605dcea6664726a9751e;p=dbsrgits%2FDBIx-Class-Historic.git TODOify a test broken by design, which exposes a bug in virtually all DBD::SQLite versions --- diff --git a/t/64db.t b/t/64db.t index 40acdc1..56a94e3 100644 --- a/t/64db.t +++ b/t/64db.t @@ -7,7 +7,7 @@ use DBICTest; my $schema = DBICTest->init_schema(); -plan tests => 3; +plan tests => 4; # add some rows inside a transaction and commit it # XXX: Is storage->dbh the only way to get a dbh? @@ -34,33 +34,61 @@ $schema->storage->txn_rollback; ($artist) = $schema->resultset("Artist")->search( artistid => 25 ); is($artist, undef, "Rollback ok"); -my $type_info = $schema->storage->columns_info_for('artist'); - -# I know this is gross but SQLite reports the size differently from release -# to release. At least this way the test still passes. -# Also it seems that some SQLite releases report stuff that isn't there as -# undef. So strip them out. -for my $col (keys %$type_info) { - for my $type (keys %{$type_info->{$col}}) { - if ($type eq 'size' or not defined $type_info->{$col}{$type} ) { - delete $type_info->{$col}{$type}; - } - } -} - -my $test_type_info = { - 'artistid' => { - 'data_type' => 'INTEGER', - 'is_nullable' => 0, +is_deeply ( + get_storage_column_info ($schema->storage, 'collection'), + { + collectionid => { + data_type => 'INTEGER', + is_nullable => 0, }, - 'name' => { - 'data_type' => 'varchar', - 'is_nullable' => 0, + name => { + data_type => 'varchar', + is_nullable => 0, }, - 'rank' => { - 'data_type' => 'integer', - 'is_nullable' => 0, + }, + 'Correctly retrieve column info (all columns non-nullable)' +); + +TODO: { + local $TODO = 'All current versions of SQLite seem to mis-report is_nullable'; + + is_deeply ( + get_storage_column_info ($schema->storage, 'artist'), + { + 'artistid' => { + 'data_type' => 'INTEGER', + 'is_nullable' => 0, + }, + 'name' => { + 'data_type' => 'varchar', + 'is_nullable' => 1, + }, + 'rank' => { + 'data_type' => 'integer', + 'is_nullable' => 0, + }, }, + 'Correctly retrieve column info (mixed null and non-null columns)' + ); }; -is_deeply($type_info, $test_type_info, 'columns_info_for - column data types'); + +sub get_storage_column_info { + my ($storage, $table) = @_; + + my $type_info = $storage->columns_info_for($table); + + # I know this is gross but SQLite reports the size differently from release + # to release. At least this way the test still passes. + # Also it seems that some SQLite releases report stuff that isn't there as + # undef. So strip them out. + for my $col (keys %$type_info) { + for my $type (keys %{$type_info->{$col}}) { + if ($type eq 'size' or not defined $type_info->{$col}{$type} ) { + delete $type_info->{$col}{$type}; + } + } + } + + return $type_info; +}