From: Nicholas Clark <nick@ccl4.org>
Date: Mon, 19 May 2008 12:40:53 +0000 (+0000)
Subject: A couple more installman tidy ups.
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3cc5758cc9b03e7b50c88cbe31e0a62befbbce74;p=p5sagit%2Fp5-mst-13.2.git

A couple more installman tidy ups.

p4raw-id: //depot/perl@33863
---

diff --git a/installman b/installman
index 9c3f873..ff196f4 100755
--- a/installman
+++ b/installman
@@ -18,8 +18,6 @@ use vars qw($Is_VMS $Is_W32 $Is_OS2 $Is_Cygwin $Is_Darwin $Is_NetWare
 
 $ENV{SHELL} = 'sh' if $^O eq 'os2';
 
-my $ver = $Config{version};     # Not used presently.
-my $release = substr($],0,3);   # Not used presently.
 my $patchlevel = substr($],3,2);
 die "Patchlevel of perl ($patchlevel)",
     "and patchlevel of config.sh ($Config{'PERL_VERSION'}) don't match\n"
@@ -46,14 +44,10 @@ GetOptions( \%opts,
 die $usage if $opts{help};
 $opts{destdir} //= '';
 
-$opts{man1dir} = "$opts{destdir}$Config{'installman1dir'}"
-    unless defined($opts{man1dir}); 
-$opts{man1ext} = $Config{'man1ext'}
-    unless defined($opts{man1ext}); 
-$opts{man3dir} = "$opts{destdir}$Config{'installman3dir'}"
-    unless defined($opts{man3dir}); 
-$opts{man3ext} = $Config{'man3ext'}
-    unless defined($opts{man3ext}); 
+foreach my $pre (qw(man1 man3)) {
+    $opts{"${pre}dir"} //= $opts{destdir} . $Config{"install${pre}dir"};
+    $opts{"${pre}ext"} //= $Config{"${pre}ext"};
+}
 $opts{silent} ||= $opts{S};
 $opts{notify} ||= $opts{n};
 $opts{verbose} ||= $opts{V} || $opts{notify};