From: Peter Rabbitson <ribasushi@cpan.org>
Date: Fri, 18 Sep 2009 12:32:15 +0000 (+0000)
Subject: Changes and dev notes in makefile
X-Git-Tag: v0.08112~10
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3c44586e85a78d10f4eaf0ec4adf2ef9b404164b;p=dbsrgits%2FDBIx-Class.git

Changes and dev notes in makefile
---

diff --git a/Changes b/Changes
index 08f0334..39d82a9 100644
--- a/Changes
+++ b/Changes
@@ -25,6 +25,9 @@ Revision history for DBIx::Class
         - More informative exception on failing _resolve_relationship
         - Fix unreported rollback exceptions in TxnScopeGuard
         - Fix overly-eager left-join chain enforcing code
+        - Warn about using distinct with an existing group_by
+        - Warn about attempting to $rs->get_column a non-unique column
+          when has_many joins are added to resultset
 
 0.08111 2009-09-06 21:58:00 (UTC)
         - The hashref to connection_info now accepts a 'dbh_maker'
diff --git a/Makefile.PL b/Makefile.PL
index 1b97a43..d2884c1 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -54,14 +54,18 @@ my %replication_requires = (
   'Hash::Merge',              => '0.11',
 );
 
-# when changing also adjust $DBIx::Class::minimum_sqlt_version
-my $sqlt_recommends = '0.11002';
-
+#************************************************************************#
+# Make *ABSOLUTELY SURE* that nothing on this list is a real require,    #
+# since every module listed in %force_requires_if_author is deleted      #
+# from the final META.yml (thus will never make it as a CPAN dependency) #
+#************************************************************************#
 my %force_requires_if_author = (
   %replication_requires,
 
+  # when changing also adjust $DBIx::Class::minimum_sqlt_version
+  'SQL::Translator'           => '0.11002',
+
 #  'Module::Install::Pod::Inherit' => '0.01',
-  'SQL::Translator'           => $sqlt_recommends,
 
   # when changing also adjust version in t/02pod.t
   'Test::Pod'                 => '1.26',
@@ -117,6 +121,11 @@ my %force_requires_if_author = (
     ) : ()
   ,
 );
+#************************************************************************#
+# Make *ABSOLUTELY SURE* that nothing on the list aboveis a real require,#
+# since every module listed in %force_requires_if_author is deleted      #
+# from the final META.yml (thus will never make it as a CPAN dependency) #
+#************************************************************************#
 
 
 install_script (qw|
diff --git a/lib/DBIx/Class.pm b/lib/DBIx/Class.pm
index 5d7a665..a2c7ce2 100644
--- a/lib/DBIx/Class.pm
+++ b/lib/DBIx/Class.pm
@@ -30,7 +30,7 @@ $VERSION = '0.08111';
 $VERSION = eval $VERSION; # numify for warning-free dev releases
 
 # what version of sqlt do we require if deploy() without a ddl_dir is invoked
-# when changing also adjust $sqlt_recommends in Makefile.PL
+# when changing also adjust the corresponding author_require in Makefile.PL
 my $minimum_sqlt_version = '0.11002';
 
 sub MODIFY_CODE_ATTRIBUTES {