From: Karen Etheridge Date: Wed, 7 Jul 2010 03:19:12 +0000 (-0700) Subject: improved grammar in test notes; use fixed test count when not skipping tests X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=commitdiff_plain;h=3b06ca5aa069a282aa319f11fe5052da9ff71f68;p=gitmo%2FMooseX-Getopt.git improved grammar in test notes; use fixed test count when not skipping tests --- diff --git a/t/107_no_auto_help.t b/t/107_no_auto_help.t index 5521bc2..c958257 100644 --- a/t/107_no_auto_help.t +++ b/t/107_no_auto_help.t @@ -13,8 +13,11 @@ use warnings; use Test::More; BEGIN { -plan skip_all => 'This test needs MooseX::SimpleConfig 0.07' - unless eval { require MooseX::SimpleConfig && MooseX::SimpleConfig->VERSION(0.07); }; + if (eval { require MooseX::SimpleConfig and MooseX::SimpleConfig->VERSION(0.07) }) { + plan tests => 3; + } else { + plan skip_all => 'This test needs MooseX::SimpleConfig 0.07'; + } } my $fail_on_exit = 1; @@ -48,8 +51,6 @@ use Test::Exception; END { ok(!$fail_on_exit, 'getoptions() lives'); - done_testing; - # cancel the non-zero exit status from _getopt_full_usage() exit 0; } diff --git a/t/109_help_flag.t b/t/109_help_flag.t index af21653..46191b9 100644 --- a/t/109_help_flag.t +++ b/t/109_help_flag.t @@ -6,7 +6,7 @@ # usage information... # This is not actually true (as of 0.29), as: -# 1. the consuming class must set up a attributes named 'help', 'usage' and +# 1. the consuming class must set up an attribute named 'help', 'usage' or # '?' to contain these command line options, which is not clearly # documented as a requirement # 2. the code is checking whether an option was parsed into an attribute